fix(icon): embiggen caret and sort carets icons #5412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enlarge the caret icons and scale friendly dimensions
remove redundant 16s
chrisconnors-ibm
requested review from
laurenmrice and
a team
as code owners
ghost
requested review from
|
Deploy preview for carbon-elements ready! Built with commit 8b7db5a |
|
Deploy preview for carbon-components-react ready! Built with commit 8b7db5a https://deploy-preview-5412--carbon-components-react.netlify.com |
… into bigger-caret
removes -16 prop for deleted 16 assets in icons.yml
chrisconnors-ibm
changed the title
|
Here are the new caret sizes mocked up with the data tree. They seem huge and would probably require extra padding when paired with the file type icon. Is this the result we were expecting from this PR?
|
slightly smaller
tweaking the size relative to other assets
|
agree: was working w Conrad as you made that accurate observation :) . original on the left, new size on the right: |
|
mocked up with the sizes just pushed: |
sort tweaked down
increase spacing between up and down
increases distance netween now awkwardly named --sort variants
chrisconnors-ibm
changed the title
chrisconnors-ibm
changed the title
|
#5421 depends on this PR. |
|
👍 |
laurenmrice
approved these changes
Feb 23, 2020
conradennis
approved these changes
Feb 24, 2020
joshblack
approved these changes
Feb 24, 2020
abbeyhrt
approved these changes
Feb 24, 2020
chrisconnors-ibm
added
status: ready to merge 🎉
and removed
status: visual review 🔍
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"A noble spirit embiggens us all"
- Jedidiah Springfield
2 for one. Enlarges the carets and sort caret variants per @mjabbink and adjusts their geometries to improve their scaling (especially to 16px) eliminating a host of bespoke 16 px icons
Changelog
Changed
32/caret--down.svg
32/caret--left.svg
32/caret--right.svg
32/caret--sort--down.svg
32/caret--sort--up.svg
32/caret--sort.svg
32/caret--up.svg
deletes -16 props from packages/icons/icons.yml for removed assets
Removed
16/caret--down.svg
16/caret--left.svg
16/caret--right.svg
16/caret--sort--down.svg
16/caret--sort--up.svg
16/caret--sort.svg
16/caret--up.svg
Testing / Reviewing
Review these preview icons on @2x and @1x screens:
https://deploy-preview-5412--carbon-elements.netlify.com/icons/examples/preview/#32%2Fcaret--down
https://deploy-preview-5412--carbon-elements.netlify.com/icons/examples/preview/#32%2Fcaret--down%20(Downsized%20to%2016)
https://deploy-preview-5412--carbon-elements.netlify.com/icons/examples/preview/#32%2Fcaret--up
https://deploy-preview-5412--carbon-elements.netlify.com/icons/examples/preview/#32%2Fcaret--up%20(Downsized%20to%2016)
https://deploy-preview-5412--carbon-elements.netlify.com/icons/examples/preview/#32%2Fcaret--left
https://deploy-preview-5412--carbon-elements.netlify.com/icons/examples/preview/#32%2Fcaret--left%20(Downsized%20to%2016)
https://deploy-preview-5412--carbon-elements.netlify.com/icons/examples/preview/#32%2Fcaret--right
https://deploy-preview-5412--carbon-elements.netlify.com/icons/examples/preview/#32%2Fcaret--right%20(Downsized%20to%2016)
https://deploy-preview-5412--carbon-elements.netlify.com/icons/examples/preview/#32%2Fcaret--sort
https://deploy-preview-5412--carbon-elements.netlify.com/icons/examples/preview/#32%2Fcaret--sort%20(Downsized%20to%2016)
https://deploy-preview-5412--carbon-elements.netlify.com/icons/examples/preview/#32%2Fcaret--sort--up
https://deploy-preview-5412--carbon-elements.netlify.com/icons/examples/preview/#32%2Fcaret--sort--up%20(Downsized%20to%2016)
https://deploy-preview-5412--carbon-elements.netlify.com/icons/examples/preview/#32%2Fcaret--sort--down
https://deploy-preview-5412--carbon-elements.netlify.com/icons/examples/preview/#32%2Fcaret--sort--down%20(Downsized%20to%2016)