Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sketch): remove autoapplied gray borders from sketch package #7429

Merged
merged 3 commits into from
Dec 14, 2020
Merged

fix(sketch): remove autoapplied gray borders from sketch package #7429

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3896576
fix(sharedStyles): remove autoapplied gray borders from sketch package
emyarod Dec 9, 2020
33e293f
refactor(shared): remove unused border clear
emyarod Dec 9, 2020
6b413be
Merge branch 'master' into 6922-sketch-gray-border-shared-style
kodiakhq[bot] Dec 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/sketch/src/commands/icons/shared.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,8 +188,6 @@ function createSVGArtboards(
});
}

shape.style.borders = [];

for (const layer of transparent) {
layer.remove();
}
Expand Down
4 changes: 3 additions & 1 deletion packages/sketch/src/tools/sharedStyles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,14 @@ export function syncSharedStyle(

// If none exists, we can create one from scratch
if (!sharedStyle) {
return SharedStyle.fromStyle({
const generatedSharedStyle = SharedStyle.fromStyle({
name,
style,
styleType,
document,
});
generatedSharedStyle.style.borders = [];
return generatedSharedStyle;
}

// Otherwise, we'll go and update values of the sharedStyle with the given
Expand Down