-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sketch): remove autoapplied gray borders from sketch package #7429
fix(sketch): remove autoapplied gray borders from sketch package #7429
Conversation
✔️ Deploy preview for carbon-elements ready! 🔨 Explore the source changes: 6b413be 🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-elements/deploys/5fd7b8c5a216b10007927b3d 😎 Browse the preview: https://deploy-preview-7429--carbon-elements.netlify.app |
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 6b413be https://deploy-preview-7429--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌮 yay!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I downloaded the newest plugin build. I am not seeing a gray border added to icons. Yay! 🎉These are the different ways I tested it:
✅ Syncing command to our existing icon sketch libraries (tested all sizes)
✅ Running the command in a brand new document (tested all sizes)
Closes #6922
This PR prevents the Sketch/DOM JS package from applying border styles to the icon symbols when the Carbon sketch plugin runs sync commands
Changelog
Changed
Removed
Testing / Reviewing
carbon-elements.sketchplugin.zip