Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sketch): remove autoapplied gray borders from sketch package #7429

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Dec 9, 2020

Closes #6922

This PR prevents the Sketch/DOM JS package from applying border styles to the icon symbols when the Carbon sketch plugin runs sync commands

Changelog

Changed

  • clear default border styles from Sketch JS package

Removed

  • unused border style resets

Testing / Reviewing

  1. Run icon sync command(s) in Sketch plugin (updated build attached below)
  2. Run the sync command again (or a different sync command)
  3. Observe that no gray border styles are added to every icon symbol

carbon-elements.sketchplugin.zip

@netlify
Copy link

netlify bot commented Dec 9, 2020

✔️ Deploy preview for carbon-elements ready!

🔨 Explore the source changes: 6b413be

🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-elements/deploys/5fd7b8c5a216b10007927b3d

😎 Browse the preview: https://deploy-preview-7429--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Dec 9, 2020

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit 6b413be

https://deploy-preview-7429--carbon-components-react.netlify.app

Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 yay!!

@emyarod emyarod mentioned this pull request Dec 10, 2020
39 tasks
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I downloaded the newest plugin build. I am not seeing a gray border added to icons. Yay! 🎉These are the different ways I tested it:

✅ Syncing command to our existing icon sketch libraries (tested all sizes)
✅ Running the command in a brand new document (tested all sizes)

@kodiakhq kodiakhq bot merged commit 2852b49 into carbon-design-system:master Dec 14, 2020
@emyarod emyarod deleted the 6922-sketch-gray-border-shared-style branch December 15, 2020 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icons sync command applies gray border style to symbols
5 participants