docs(Storybook): update storybook to use carbon styles #7866
Conversation
|
Deploy preview for carbon-elements ready! Built with commit 9277e86 |
|
Deploy preview for carbon-components-react ready! Built with commit 9277e86 https://deploy-preview-7866--carbon-components-react.netlify.app |
|
Deploy preview for carbon-elements ready! Built with commit c9152d3 |
|
Deploy preview for carbon-components-react ready! Built with commit c9152d3 https://deploy-preview-7866--carbon-components-react.netlify.app |
|
This looks nice! I like it reflecting the other storybooks and the carbon brand more. A intro page would be nice too so we don't have to link to accordion or another component when sharing a link to it as well. But I agree that's not a stop ship. Some small visual updates if you're looking for recommendations:
|
|
@aagonzales Thanks! I'll make those updates. If you have any quick mocks for an intro page I'd be happy to add that in, but we can add that in later if you're busy 🙂 |
|
@joshblack @jnm2377 I grouped the components into categories, so you may want to take another look and see if this is something we would want to do. We could probably group a few more components together (Tooltip variants stand out), but figured this was a quick easy start to see if we wanted to stick with this @aagonzales style changes made and welcome page added 🎉 |
|
Oooh, I really like the groups. It feels a lot more organized. Esp having deprecated and experimental in their own sections. This is great!!! Thanks for doing this! 🔥 🎉 💯 |
|
@tw15egan love it 🔥 |
tw15egan
added
status: ready to merge 🎉
and removed
status: ready for review 👀
status: visual review 🔍
labels
originally added in carbon-design-system#7866, relocated (carbon-design-system#8630), but never reverted (carbon-design-system#8684)
originally added in carbon-design-system#7866, relocated (carbon-design-system#8630), but never reverted (carbon-design-system#8684)
* chore(react): begin storybook v6 migration * fix(storybook): use carbon-react babel-loader exclusions * docs(Tag): update storybook action import * chore: regenerate lockfile * chore: dedupe packages * docs(storybook): restore favicon originally added in #7866, relocated (#8630), but never reverted (#8684) * docs(storybook): add style overrides * chore: update lockfile * style(Welcome): fix background Co-authored-by: TJ Egan <tw15egan@gmail.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Updates our Storybook environment to use Carbon styles to better match some of the other Carbon storybook environments out there. Wonder if we also want to add some sort of intro page like Carbon Charts?
Changelog
New
Testing / Reviewing
Everything should work the same, let me know if we want to tweak any of the colors/styles, more info can be found in the storybook documentation