Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade storybook from v5 to v6 #9062

Merged
merged 11 commits into from
Jul 1, 2021

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Jun 29, 2021

Closes #8883

related #8702

This PR updates the v5 Storybook to v6 for packages/react so that there are no clashes with the carbon-react storybook and so that component story knobs are functional again

Changelog

Changed

  • upgrade packages/react storybook
  • regenerate lockfiles to update dependency versions
  • fix outdated story imports

Testing / Reviewing

Confirm that component story knobs are functional again as well as the existing Carbon theme and type addon knobs

@netlify
Copy link

netlify bot commented Jun 29, 2021

❌ Deploy Preview for carbon-react-next failed.

🔨 Explore the source changes: fb6dc58

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/60de1d5f7ac7c000075cf72d

@joshblack
Copy link
Contributor

@emyarod is there a way to upgrade without regenerating the lockfile? Seems like we're getting a lot of big jumps with dependencies, could this be something that we use yarn upgrade-interactive to help out with?

@emyarod
Copy link
Member Author

emyarod commented Jun 29, 2021

@joshblack I tried not to touch the lockfile but that was the only way I could fix storybook build issues after migrating to v6. I suppose we can try and isolate the packages that need to be bumped with upgrade-interactive

@netlify
Copy link

netlify bot commented Jun 29, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: fb6dc58

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60de1d5fe6c009000795e32b

😎 Browse the preview: https://deploy-preview-9062--carbon-elements.netlify.app

@joshblack
Copy link
Contributor

@emyarod got it, it would be best to avoid doing a whole lockfile update and instead use upgrade-interactive along with yarn why to figure out why certain entries in the lockfile are old or duplicated which are causing the build to be a problem

@netlify
Copy link

netlify bot commented Jun 29, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: fb6dc58

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60de1d5fdd295a000785f90b

😎 Browse the preview: https://deploy-preview-9062--carbon-components-react.netlify.app

@joshblack
Copy link
Contributor

Looking great! I think the only thing left is the deploy step which seems to be failing with:

ERR! Failed to load static files, no such directory: packages/react/.storybook/assets
ERR! Make sure this directory exists, or omit the -s (--static-dir) option.

@emyarod
Copy link
Member Author

emyarod commented Jun 30, 2021

looks like it was moved in #8630 but not reverted in #8684

not sure if we wanted to keep it but I added it back even though it's not in carbon-react currently

@joshblack
Copy link
Contributor

@emyarod it looks like the color contrast on the selected story text might have changed?

image

Not sure if it's a new theme option or something 🤔

@emyarod
Copy link
Member Author

emyarod commented Jun 30, 2021

yeah seems to be caused by the new default storybook styles

@joshblack
Copy link
Contributor

🎉

Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looking/working great, nice work! 🎉

@kodiakhq kodiakhq bot merged commit f8f2904 into carbon-design-system:main Jul 1, 2021
@emyarod emyarod deleted the 8883-upgrade-storybook branch July 6, 2021 14:25
@emyarod emyarod mentioned this pull request Jul 12, 2021
62 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ComboBox storybook props not visible or functional
3 participants