-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade storybook from v5 to v6 #9062
chore: upgrade storybook from v5 to v6 #9062
Conversation
❌ Deploy Preview for carbon-react-next failed. 🔨 Explore the source changes: fb6dc58 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/60de1d5f7ac7c000075cf72d |
@emyarod is there a way to upgrade without regenerating the lockfile? Seems like we're getting a lot of big jumps with dependencies, could this be something that we use |
@joshblack I tried not to touch the lockfile but that was the only way I could fix storybook build issues after migrating to v6. I suppose we can try and isolate the packages that need to be bumped with upgrade-interactive |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: fb6dc58 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60de1d5fe6c009000795e32b 😎 Browse the preview: https://deploy-preview-9062--carbon-elements.netlify.app |
@emyarod got it, it would be best to avoid doing a whole lockfile update and instead use |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: fb6dc58 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60de1d5fdd295a000785f90b 😎 Browse the preview: https://deploy-preview-9062--carbon-components-react.netlify.app |
3f6f492
to
68868c8
Compare
Looking great! I think the only thing left is the deploy step which seems to be failing with:
|
9c56efe
to
6c13279
Compare
@emyarod it looks like the color contrast on the selected story text might have changed? Not sure if it's a new theme option or something 🤔 |
originally added in carbon-design-system#7866, relocated (carbon-design-system#8630), but never reverted (carbon-design-system#8684)
5cf475c
to
ef9714b
Compare
yeah seems to be caused by the new default storybook styles |
🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looking/working great, nice work! 🎉
Closes #8883
related #8702
This PR updates the v5 Storybook to v6 for
packages/react
so that there are no clashes with thecarbon-react
storybook and so that component story knobs are functional againChangelog
Changed
packages/react
storybookTesting / Reviewing
Confirm that component story knobs are functional again as well as the existing Carbon theme and type addon knobs