Quote step names to work around mermaid-js/mermaid#2495 #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chancez
added a commit
to cilium/cilium
that referenced
this pull request
Jul 23, 2024
…-action Running on my branch of the workflow-telemetry-action with catchpoint/workflow-telemetry-action#77 to see if it can help the rendering problem in #32241. Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
Fixes catchpoint#76 Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
chancez
force-pushed
the
pr/chancez/quote_step_names
branch
from
d41dfbc
to
881045c
Compare
|
Ok so that worked. @serkan-ozal could you take a look? |
chancez
added a commit
to cilium/cilium
that referenced
this pull request
Jul 30, 2024
Basically, workflow telemetry uses step names for gantt charts which uses Github's native support for mermaidjs for rendering the charts in issues and PRs. However mermaidjs has an issue (mermaid-js/mermaid#2495) when you use mermaid reserved keywords in node names/text. To fix rendering of the ipsec upgrade workflow's telemetry, avoid the use of the "call" keyword. This is a work around for catchpoint/workflow-telemetry-action#76. If an when catchpoint/workflow-telemetry-action#77 is merged, we do not need to be concerned with workflow step names. Fixes #32241 Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
github-merge-queue bot
pushed a commit
to cilium/cilium
that referenced
this pull request
Jul 31, 2024
Basically, workflow telemetry uses step names for gantt charts which uses Github's native support for mermaidjs for rendering the charts in issues and PRs. However mermaidjs has an issue (mermaid-js/mermaid#2495) when you use mermaid reserved keywords in node names/text. To fix rendering of the ipsec upgrade workflow's telemetry, avoid the use of the "call" keyword. This is a work around for catchpoint/workflow-telemetry-action#76. If an when catchpoint/workflow-telemetry-action#77 is merged, we do not need to be concerned with workflow step names. Fixes #32241 Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
nbusseneau
pushed a commit
to cilium/cilium
that referenced
this pull request
Aug 3, 2024
[ upstream commit 9592c69 ] Basically, workflow telemetry uses step names for gantt charts which uses Github's native support for mermaidjs for rendering the charts in issues and PRs. However mermaidjs has an issue (mermaid-js/mermaid#2495) when you use mermaid reserved keywords in node names/text. To fix rendering of the ipsec upgrade workflow's telemetry, avoid the use of the "call" keyword. This is a work around for catchpoint/workflow-telemetry-action#76. If an when catchpoint/workflow-telemetry-action#77 is merged, we do not need to be concerned with workflow step names. Fixes #32241 Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com> Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
nbusseneau
pushed a commit
to cilium/cilium
that referenced
this pull request
Aug 3, 2024
[ upstream commit 9592c69 ] Basically, workflow telemetry uses step names for gantt charts which uses Github's native support for mermaidjs for rendering the charts in issues and PRs. However mermaidjs has an issue (mermaid-js/mermaid#2495) when you use mermaid reserved keywords in node names/text. To fix rendering of the ipsec upgrade workflow's telemetry, avoid the use of the "call" keyword. This is a work around for catchpoint/workflow-telemetry-action#76. If an when catchpoint/workflow-telemetry-action#77 is merged, we do not need to be concerned with workflow step names. Fixes #32241 Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com> Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
gandro
pushed a commit
to cilium/cilium
that referenced
this pull request
Aug 6, 2024
[ upstream commit 9592c69 ] Basically, workflow telemetry uses step names for gantt charts which uses Github's native support for mermaidjs for rendering the charts in issues and PRs. However mermaidjs has an issue (mermaid-js/mermaid#2495) when you use mermaid reserved keywords in node names/text. To fix rendering of the ipsec upgrade workflow's telemetry, avoid the use of the "call" keyword. This is a work around for catchpoint/workflow-telemetry-action#76. If an when catchpoint/workflow-telemetry-action#77 is merged, we do not need to be concerned with workflow step names. Fixes #32241 Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com> Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76
I still need to see if I can test this with our existing workflows, but I figured I would open a PR for feedback since I don't really have any experience using mermaid charts myself, and perhaps there's a better alternative.