Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github: Update tests-ipsec-upgrade to use fork of workflow-telemetry-action #33980

Closed
wants to merge 1 commit into from

Conversation

chancez
Copy link
Contributor

@chancez chancez commented Jul 23, 2024

Running on my branch of the workflow-telemetry-action with catchpoint/workflow-telemetry-action#77 to see if it can help the rendering problem in #32241.

If this works I'll report back in catchpoint/workflow-telemetry-action#77. However there's not been many recent releases so we'll have to see how they respond if we want this fix.

…-action

Running on my branch of the workflow-telemetry-action with
catchpoint/workflow-telemetry-action#77 to see
if it can help the rendering problem in #32241.

Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
@chancez chancez self-assigned this Jul 23, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 23, 2024
@michi-covalent
Copy link
Contributor

/ci-ipsec-upgrade

@chancez
Copy link
Contributor Author

chancez commented Jul 24, 2024

Forgot to compile the typescript in my PR 😂

@chancez
Copy link
Contributor Author

chancez commented Jul 24, 2024

Ok I updated my PR upstream to rebuild the action.

@chancez
Copy link
Contributor Author

chancez commented Jul 24, 2024

/ci-ipsec-upgrade

@chancez
Copy link
Contributor Author

chancez commented Jul 24, 2024

It worked 🥳
Screenshot 2024-07-23 at 5 11 35 PM

@chancez
Copy link
Contributor Author

chancez commented Jul 30, 2024

This confirms my PR in the telemetry action works. For now I have a work-around here #34097 which involves removing the usage of call in the workflow step effected.

@chancez chancez closed this Jul 30, 2024
@chancez chancez deleted the pr/chancez/test_fixing_telemetry branch July 30, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dont-merge/needs-release-note-label The author needs to describe the release impact of these changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants