Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.10.3 has a broken PR added #2311

Closed
mindstyle85 opened this issue Jun 3, 2023 · 1 comment · Fixed by #2313
Closed

v0.10.3 has a broken PR added #2311

mindstyle85 opened this issue Jun 3, 2023 · 1 comment · Fixed by #2313
Assignees
@walldiss
Labels
bug Something isn't working external Issues created by non node team members

Comments

@mindstyle85
Copy link

Celestia Node version

0.10.3

OS

n/a

Install tools

No response

Others

No response

Steps to reproduce it

https://github.com/celestiaorg/celestia-node/pull/2277/files

Error: failed to resolve DNS record: lookup https://rpc-blockspacerace.pops.one/: no such host

Expected result

expected it should work with domains too

Actual result

n/a

Relevant log output

No response

Notes

No response
@mindstyle85 mindstyle85 added the bug Something isn't working label Jun 3, 2023
@github-actions github-actions bot added the external Issues created by non node team members label Jun 3, 2023
@walldiss walldiss mentioned this issue Jun 3, 2023
Merged
@walldiss
Copy link
Member

walldiss commented Jun 3, 2023

Thank you for this one! I've create a fix, that will allow to use url with schema. For now, please use only host part:

--core.ip rpc-blockspacerace.pops.one

@walldiss walldiss self-assigned this Jun 3, 2023
walldiss added a commit that referenced this issue Jun 5, 2023
@walldiss
fix(nodebuilder): fix parsing url for core.ip (#2313)
118c4a9 
## Overview

Resolves #2311
Wondertan pushed a commit that referenced this issue Jun 6, 2023
@walldiss @Wondertan
fix(nodebuilder): fix parsing url for core.ip (#2313)
5c9eca8 
## Overview

Resolves #2311
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@walldiss walldiss

Labels
bug Something isn't working external Issues created by non node team members
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(nodebuilder): fix parsing url for core.ip walldiss/celestia-node
2 participants
@walldiss @mindstyle85