Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nodebuilder): fix parsing url for core.ip #2313

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

walldiss
Copy link
Member

@walldiss walldiss commented Jun 3, 2023

Overview

Resolves #2311

@walldiss walldiss added area:node Node kind:fix Attached to bug-fixing PRs labels Jun 3, 2023
@walldiss walldiss self-assigned this Jun 3, 2023
@Wondertan
Copy link
Member

Seems to contain unrelated changes

@codecov-commenter
Copy link

Codecov Report

Merging #2313 (795cec9) into main (504ff93) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2313      +/-   ##
==========================================
- Coverage   50.61%   50.59%   -0.03%     
==========================================
  Files         154      154              
  Lines        9729     9729              
==========================================
- Hits         4924     4922       -2     
- Misses       4379     4381       +2     
  Partials      426      426              

see 4 files with indirect coverage changes

@walldiss walldiss merged commit 118c4a9 into celestiaorg:main Jun 5, 2023
Wondertan pushed a commit that referenced this pull request Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:node Node kind:fix Attached to bug-fixing PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v0.10.3 has a broken PR added
4 participants