Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't report resistance if all regions have bad coverage #467

Closed
donkirkby opened this issue May 2, 2019 · 1 comment
Closed

Don't report resistance if all regions have bad coverage #467

donkirkby opened this issue May 2, 2019 · 1 comment

Comments

@donkirkby
Copy link
Member

We recently changed the way MIDI samples get combined with their whole-genome partners, particularly in issue #462. Those changes caused some strange results, like sample 90154A_HCV in the 22-Mar-2019 run. It mapped nicely to HCV-1a, while its MIDI partner 90154AMIDI_MidHCV mapped nicely to HCV-1a and badly to HCV-3a. However, it now reports resistance for HCV-1a and HCV-3a.

Resistance should only be reported for a genotype if at least one of the four regions has good coverage:

  • NS3
  • NS5a
  • NS5b (whole genome part)
  • NS5b (MIDI part)

Currently, a region's coverage is considered good if it has average coverage of at least 100, and the start and end positions have coverage of at least 100.

Options for new coverage requirements:

  • All positions have coverage of at least 100.
  • All resistance mutation positions for that genotype have coverage of at least 100.
@donkirkby donkirkby added the bug label May 2, 2019
@donkirkby donkirkby added this to the 7.10 - Container Runs milestone May 2, 2019
@donkirkby
Copy link
Member Author

Chanson asked for the second option.

donkirkby added a commit that referenced this issue May 13, 2019
Also link to DOI number on Zenodo's web site.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant