Riemann fit updates #190
Merged
Riemann fit updates #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Riemann Fit has been reworked so that both barrel and forward cases are naturally supported without branching. The underlying assumption is the uniform material distribution within the Pixel Tracker. Also the line fit has been reworked and is now using an ordinary least square fit in the S-Z plane. The motivations and explanation are inside the comments into the code.
Validation summaryReference release CMSSW_10_2_6 at 64135c9
|
|
Looks good:
|
|
|
|
No changes to the profiling reports. |
fwyzard
pushed a commit
that referenced
this pull request
Jan 9, 2019
fwyzard
added a commit
that referenced
this pull request
Oct 8, 2020
The Riemann Fit has been reworked so that both barrel and forward cases are naturally supported without branching. The underlying assumption is the uniform material distribution within the Pixel Tracker. The line fit has been reworked and is now using an ordinary least square fit in the S-Z plane. See the motivations and explanations inside the comments in the code. Additional changes: - code clean up - remove unused functions - fix standalone test of RiemannFit on GPU
fwyzard
pushed a commit
that referenced
this pull request
Oct 8, 2020
fwyzard
added a commit
that referenced
this pull request
Oct 20, 2020
The Riemann Fit has been reworked so that both barrel and forward cases are naturally supported without branching. The underlying assumption is the uniform material distribution within the Pixel Tracker. The line fit has been reworked and is now using an ordinary least square fit in the S-Z plane. See the motivations and explanations inside the comments in the code. Additional changes: - code clean up - remove unused functions - fix standalone test of RiemannFit on GPU
fwyzard
pushed a commit
that referenced
this pull request
Oct 20, 2020
fwyzard
added a commit
that referenced
this pull request
Oct 20, 2020
The Riemann Fit has been reworked so that both barrel and forward cases are naturally supported without branching. The underlying assumption is the uniform material distribution within the Pixel Tracker. The line fit has been reworked and is now using an ordinary least square fit in the S-Z plane. See the motivations and explanations inside the comments in the code. Additional changes: - code clean up - remove unused functions - fix standalone test of RiemannFit on GPU
fwyzard
pushed a commit
that referenced
this pull request
Oct 20, 2020
fwyzard
added a commit
that referenced
this pull request
Oct 23, 2020
The Riemann Fit has been reworked so that both barrel and forward cases are naturally supported without branching. The underlying assumption is the uniform material distribution within the Pixel Tracker. The line fit has been reworked and is now using an ordinary least square fit in the S-Z plane. See the motivations and explanations inside the comments in the code. Additional changes: - code clean up - remove unused functions - fix standalone test of RiemannFit on GPU
fwyzard
pushed a commit
that referenced
this pull request
Oct 23, 2020
fwyzard
added a commit
that referenced
this pull request
Nov 6, 2020
The Riemann Fit has been reworked so that both barrel and forward cases are naturally supported without branching. The underlying assumption is the uniform material distribution within the Pixel Tracker. The line fit has been reworked and is now using an ordinary least square fit in the S-Z plane. See the motivations and explanations inside the comments in the code. Additional changes: - code clean up - remove unused functions - fix standalone test of RiemannFit on GPU
fwyzard
pushed a commit
that referenced
this pull request
Nov 6, 2020
fwyzard
added a commit
that referenced
this pull request
Nov 6, 2020
The Riemann Fit has been reworked so that both barrel and forward cases are naturally supported without branching. The underlying assumption is the uniform material distribution within the Pixel Tracker. The line fit has been reworked and is now using an ordinary least square fit in the S-Z plane. See the motivations and explanations inside the comments in the code. Additional changes: - code clean up - remove unused functions - fix standalone test of RiemannFit on GPU
fwyzard
pushed a commit
that referenced
this pull request
Nov 6, 2020
fwyzard
added a commit
that referenced
this pull request
Nov 16, 2020
The Riemann Fit has been reworked so that both barrel and forward cases are naturally supported without branching. The underlying assumption is the uniform material distribution within the Pixel Tracker. The line fit has been reworked and is now using an ordinary least square fit in the S-Z plane. See the motivations and explanations inside the comments in the code. Additional changes: - code clean up - remove unused functions - fix standalone test of RiemannFit on GPU
fwyzard
pushed a commit
that referenced
this pull request
Nov 16, 2020
fwyzard
added a commit
that referenced
this pull request
Nov 27, 2020
The Riemann Fit has been reworked so that both barrel and forward cases are naturally supported without branching. The underlying assumption is the uniform material distribution within the Pixel Tracker. The line fit has been reworked and is now using an ordinary least square fit in the S-Z plane. See the motivations and explanations inside the comments in the code. Additional changes: - code clean up - remove unused functions - fix standalone test of RiemannFit on GPU
fwyzard
added a commit
that referenced
this pull request
Nov 27, 2020
fwyzard
pushed a commit
that referenced
this pull request
Dec 26, 2020
The Riemann Fit has been reworked so that both barrel and forward cases are naturally supported without branching. The underlying assumption is the uniform material distribution within the Pixel Tracker. The line fit has been reworked and is now using an ordinary least square fit in the S-Z plane. See the motivations and explanations inside the comments in the code. Additional changes: - code clean up - remove unused functions - fix standalone test of RiemannFit on GPU
fwyzard
pushed a commit
that referenced
this pull request
Dec 26, 2020
fwyzard
added a commit
that referenced
this pull request
Jan 15, 2021
The Riemann Fit has been reworked so that both barrel and forward cases are naturally supported without branching. The underlying assumption is the uniform material distribution within the Pixel Tracker. The line fit has been reworked and is now using an ordinary least square fit in the S-Z plane. See the motivations and explanations inside the comments in the code. Additional changes: - code clean up - remove unused functions - fix standalone test of RiemannFit on GPU
fwyzard
pushed a commit
that referenced
this pull request
Jan 15, 2021
fwyzard
added a commit
that referenced
this pull request
Mar 23, 2021
The Riemann Fit has been reworked so that both barrel and forward cases are naturally supported without branching. The underlying assumption is the uniform material distribution within the Pixel Tracker. The line fit has been reworked and is now using an ordinary least square fit in the S-Z plane. See the motivations and explanations inside the comments in the code. Additional changes: - code clean up - remove unused functions - fix standalone test of RiemannFit on GPU
fwyzard
pushed a commit
that referenced
this pull request
Mar 23, 2021
fwyzard
added a commit
that referenced
this pull request
Apr 1, 2021
The Riemann Fit has been reworked so that both barrel and forward cases are naturally supported without branching. The underlying assumption is the uniform material distribution within the Pixel Tracker. The line fit has been reworked and is now using an ordinary least square fit in the S-Z plane. See the motivations and explanations inside the comments in the code. Additional changes: - code clean up - remove unused functions - fix standalone test of RiemannFit on GPU
fwyzard
pushed a commit
that referenced
this pull request
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From @rovere:
The Riemann Fit has been reworked so that both barrel and forward cases are naturally supported without branching. The underlying assumption is the uniform material distribution within the Pixel Tracker.
The line fit has been reworked and is now using an ordinary least square fit in the S-Z plane.
The motivations and explanation are inside the comments into the code.