Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patatrack integration - Pixel track reconstruction (10/N) #31722

Merged

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Oct 8, 2020

PR description:

Data formats and algorithms for the Pixel track reconstruction running on GPU.
Implements building the pixel pairs, running the CA, applying the Fishbone cleaning, and performing either Riemann or Broken Line fit to produce tracks made by triplets and/or ntuplets.

Includes changes to "MTV" for the validation of pixel-only tracks.

PR validation:

Changes in use in the Patatrack releases.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Includes changes from:

@cmsbuild cmsbuild added this to the CMSSW_11_2_X milestone Oct 8, 2020
@fwyzard
Copy link
Contributor Author

fwyzard commented Oct 8, 2020

For all questions, please address @makortel @felicepantaleo @VinInn @rovere .
For all changes, please make PRs against cms-patatrack:patatrack_integration_10_N_pixel_tracks .

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2020

-code-checks

ERROR: Build errors found during clang-tidy run.

CUDADataFormats/TrackingRecHit/interface/TrackingRecHit2DSOAView.h:6:10: error: 'CUDADataFormats/SiPixelCluster/interface/gpuClusteringConstants.h' file not found [clang-diagnostic-error]
#include "CUDADataFormats/SiPixelCluster/interface/gpuClusteringConstants.h"
         ^
Suppressed 221 warnings (220 in non-user code, 1 with check filters).
--
RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernelsImpl.h:14:10: error: 'RecoLocalTracker/SiPixelRecHits/interface/pixelCPEforGPU.h' file not found [clang-diagnostic-error]
#include "RecoLocalTracker/SiPixelRecHits/interface/pixelCPEforGPU.h"
         ^
Suppressed 330 warnings (329 in non-user code, 1 with check filters).
--
CUDADataFormats/Track/interface/PixelTrackHeterogeneous.h:7:10: error: 'CUDADataFormats/Common/interface/HeterogeneousSoA.h' file not found [clang-diagnostic-error]
#include "CUDADataFormats/Common/interface/HeterogeneousSoA.h"
         ^
Suppressed 314 warnings (313 in non-user code, 1 with check filters).
--
CUDADataFormats/Track/interface/PixelTrackHeterogeneous.h:7:10: error: 'CUDADataFormats/Common/interface/HeterogeneousSoA.h' file not found [clang-diagnostic-error]
#include "CUDADataFormats/Common/interface/HeterogeneousSoA.h"
         ^
Suppressed 315 warnings (314 in non-user code, 1 with check filters).
--
RecoPixelVertexing/PixelTrackFitting/plugins/PixelTrackSoAFromCUDA.cc:4:10: error: 'CUDADataFormats/Common/interface/HostProduct.h' file not found [clang-diagnostic-error]
#include "CUDADataFormats/Common/interface/HostProduct.h"
         ^
Suppressed 740 warnings (739 in non-user code, 1 with check filters).
--
CUDADataFormats/TrackingRecHit/interface/TrackingRecHit2DSOAView.h:6:10: error: 'CUDADataFormats/SiPixelCluster/interface/gpuClusteringConstants.h' file not found [clang-diagnostic-error]
#include "CUDADataFormats/SiPixelCluster/interface/gpuClusteringConstants.h"
         ^
Suppressed 993 warnings (992 in non-user code, 1 with check filters).
--
CUDADataFormats/Track/interface/PixelTrackHeterogeneous.h:7:10: error: 'CUDADataFormats/Common/interface/HeterogeneousSoA.h' file not found [clang-diagnostic-error]
#include "CUDADataFormats/Common/interface/HeterogeneousSoA.h"
         ^
Suppressed 861 warnings (860 in non-user code, 1 with check filters).
--
CUDADataFormats/Track/interface/PixelTrackHeterogeneous.h:7:10: error: 'CUDADataFormats/Common/interface/HeterogeneousSoA.h' file not found [clang-diagnostic-error]
#include "CUDADataFormats/Common/interface/HeterogeneousSoA.h"
         ^
Suppressed 957 warnings (956 in non-user code, 1 with check filters).
--
CUDADataFormats/TrackingRecHit/interface/TrackingRecHit2DSOAView.h:6:10: error: 'CUDADataFormats/SiPixelCluster/interface/gpuClusteringConstants.h' file not found [clang-diagnostic-error]
#include "CUDADataFormats/SiPixelCluster/interface/gpuClusteringConstants.h"
         ^
Suppressed 1136 warnings (1135 in non-user code, 1 with check filters).
--
RecoPixelVertexing/PixelTrackFitting/plugins/PixelTrackProducerFromSoA.cc:30:10: error: 'CUDADataFormats/Common/interface/HostProduct.h' file not found [clang-diagnostic-error]
#include "CUDADataFormats/Common/interface/HostProduct.h"
         ^
Suppressed 1300 warnings (1299 in non-user code, 1 with check filters).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:128: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

fwyzard added a commit to fwyzard/cms-bot that referenced this pull request Oct 10, 2020
See
[#31703](cms-sw/cmssw#31703) Patatrack integration - common data formats (5/N)
[#31704](cms-sw/cmssw#31704) Patatrack integration - calorimeters shared code (6/N)
[#31719](cms-sw/cmssw#31719) Patatrack integration - ECAL local reconstruction (7/N)
[#31720](cms-sw/cmssw#31720) Patatrack integration - HCAL local reconstruction (8/N)
[#31721](cms-sw/cmssw#31721) Patatrack integration - Pixel local reconstruction (9/N)
[#31722](cms-sw/cmssw#31722) Patatrack integration - Pixel track reconstruction (10/N)
[#31723](cms-sw/cmssw#31723) Patatrack integration - Pixel vertex reconstruction (11/N)
fwyzard added a commit to fwyzard/cms-bot that referenced this pull request Oct 10, 2020
See
  - cms-sw/cmssw#31703: Patatrack integration - common data formats (5/N)
  - cms-sw/cmssw#31704: Patatrack integration - calorimeters shared code (6/N)
  - cms-sw/cmssw#31719: Patatrack integration - ECAL local reconstruction (7/N)
  - cms-sw/cmssw#31720: Patatrack integration - HCAL local reconstruction (8/N)
  - cms-sw/cmssw#31721: Patatrack integration - Pixel local reconstruction (9/N)
  - cms-sw/cmssw#31722: Patatrack integration - Pixel track reconstruction (10/N)
  - cms-sw/cmssw#31723: Patatrack integration - Pixel vertex reconstruction (11/N)
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 19, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) #31854,#31721,#31723
Test Parameters:

@cmsbuild
Copy link
Contributor

-1
@fwyzard This pull request cannot be automatically merged, could you please rebase it?

You can see the log for git cms-merge-topic here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-31722/10089/git-merge-result

@fwyzard fwyzard force-pushed the patatrack_integration_10_N_pixel_tracks branch from 7c159b2 to 4efcb3f Compare October 20, 2020 11:25
ericcano added a commit to ericcano/cmssw that referenced this pull request May 21, 2021
ericcano added a commit to ericcano/cmssw that referenced this pull request May 21, 2021
…sw#614)

Used accessors in all cases. This commit does not change the memory layout of the class.
Also fixed C-style casts (reinterpret casts are needed here).
cms-sw#31722 (comment)
cms-sw#31722 (comment)
ericcano added a commit to ericcano/cmssw that referenced this pull request May 21, 2021
ericcano added a commit to ericcano/cmssw that referenced this pull request May 21, 2021
ericcano added a commit to ericcano/cmssw that referenced this pull request May 21, 2021
ericcano added a commit to ericcano/cmssw that referenced this pull request May 21, 2021
ericcano added a commit to ericcano/cmssw that referenced this pull request May 26, 2021
Also removed addition of transposed matrix by directly copying the needed elements.
cms-sw#31722 (comment)
cms-sw#31722 (comment)
ericcano added a commit to ericcano/cmssw that referenced this pull request May 26, 2021
ericcano added a commit to ericcano/cmssw that referenced this pull request May 26, 2021
Also introduced a computation simplification suggested in:
cms-sw#31722 (comment)
ericcano added a commit to ericcano/cmssw that referenced this pull request May 26, 2021
ericcano added a commit to ericcano/cmssw that referenced this pull request May 27, 2021
Also removed addition of transposed matrix by directly copying the needed elements.
cms-sw#31722 (comment)
cms-sw#31722 (comment)
ericcano added a commit to ericcano/cmssw that referenced this pull request May 27, 2021
ericcano added a commit to ericcano/cmssw that referenced this pull request May 27, 2021
Also introduced a computation simplification suggested in:
cms-sw#31722 (comment)
ericcano added a commit to ericcano/cmssw that referenced this pull request May 27, 2021
ericcano added a commit to ericcano/cmssw that referenced this pull request May 27, 2021
ericcano added a commit to ericcano/cmssw that referenced this pull request May 27, 2021
…sw#614)

Used accessors in all cases. This commit does not change the memory layout of the class.
Also fixed C-style casts (reinterpret casts are needed here).
cms-sw#31722 (comment)
cms-sw#31722 (comment)
ericcano added a commit to ericcano/cmssw that referenced this pull request May 27, 2021
ericcano added a commit to ericcano/cmssw that referenced this pull request May 27, 2021
ericcano added a commit to ericcano/cmssw that referenced this pull request May 27, 2021
ericcano added a commit to ericcano/cmssw that referenced this pull request May 27, 2021
@fwyzard fwyzard deleted the patatrack_integration_10_N_pixel_tracks branch May 4, 2022 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.