Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop obsolete heterogenous framework #416

Merged

Conversation

fwyzard
Copy link

@fwyzard fwyzard commented Nov 27, 2019

Drop the obsolete attempt of a heterogeneous framework:

  • HeterogeneousCore/Producer
  • HeterogeneousCore/Product
  • HeterogeneousCore/CUDACore/*/GPUCuda.*

and update the BuildFiles accordingly.

@fwyzard
Copy link
Author

fwyzard commented Nov 27, 2019

@makortel have I missed anything ?

@fwyzard
Copy link
Author

fwyzard commented Nov 27, 2019

Validation summary

Reference release CMSSW_11_0_0_pre11 at 5b0a828
Development branch CMSSW_11_0_X_Patatrack at dcfe37d
Testing PRs:

Validation plots

/RelValTTbar_13/CMSSW_10_6_0-PU25ns_106X_upgrade2018_realistic_v4-v1/GEN-SIM-DIGI-RAW

  • tracking validation plots and summary for workflow 10824.5
  • tracking validation plots and summary for workflow 10824.51
  • tracking validation plots and summary for workflow 10824.52

/RelValZMM_13/CMSSW_10_6_0-PU25ns_106X_upgrade2018_realistic_v4-v1/GEN-SIM-DIGI-RAW

  • tracking validation plots and summary for workflow 10824.5
  • tracking validation plots and summary for workflow 10824.51
  • tracking validation plots and summary for workflow 10824.52

/RelValTTbar_13/CMSSW_10_6_0-PU25ns_106X_upgrade2018_design_v3-v1/GEN-SIM-DIGI-RAW

  • tracking validation plots and summary for workflow 10824.5
  • tracking validation plots and summary for workflow 10824.51
  • tracking validation plots and summary for workflow 10824.52

Throughput plots

/EphemeralHLTPhysics1/Run2018D-v1/RAW run=323775 lumi=53

scan-136.86452.png
zoom-136.86452.png

logs and nvprof/nvvp profiles

/RelValTTbar_13/CMSSW_10_6_0-PU25ns_106X_upgrade2018_realistic_v4-v1/GEN-SIM-DIGI-RAW

  • reference release, workflow 10824.5
  • development release, workflow 10824.5
  • development release, workflow 10824.51
  • development release, workflow 10824.52
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
  • development release, workflow 136.86452
  • testing release, workflow 10824.5
  • testing release, workflow 10824.51
  • testing release, workflow 10824.52
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
  • testing release, workflow 136.86452

/RelValZMM_13/CMSSW_10_6_0-PU25ns_106X_upgrade2018_realistic_v4-v1/GEN-SIM-DIGI-RAW

  • reference release, workflow 10824.5
  • development release, workflow 10824.5
  • development release, workflow 10824.51
  • development release, workflow 10824.52
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
  • development release, workflow 136.86452
  • testing release, workflow 10824.5
  • testing release, workflow 10824.51
  • testing release, workflow 10824.52
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
  • testing release, workflow 136.86452

/RelValTTbar_13/CMSSW_10_6_0-PU25ns_106X_upgrade2018_design_v3-v1/GEN-SIM-DIGI-RAW

  • reference release, workflow 10824.5
  • development release, workflow 10824.5
  • development release, workflow 10824.51
  • development release, workflow 10824.52
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
  • development release, workflow 136.86452
  • testing release, workflow 10824.5
  • testing release, workflow 10824.51
  • testing release, workflow 10824.52
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
  • testing release, workflow 136.86452

Logs

The full log is available at https://patatrack.web.cern.ch/patatrack/validation/pulls/1d36840d52d6feb806cb1bc08eb3156c39bb3c4b/log .

@fwyzard
Copy link
Author

fwyzard commented Nov 27, 2019

No impact on physics or throughput, as expected.

@makortel
Copy link

@makortel have I missed anything ?

This should be all, thanks.

@fwyzard fwyzard merged commit b355dfd into cms-patatrack:CMSSW_11_0_X_Patatrack Nov 27, 2019
@fwyzard fwyzard deleted the drop_obsolete_framework branch November 27, 2019 14:43
fwyzard added a commit that referenced this pull request Oct 7, 2020
fwyzard added a commit that referenced this pull request Oct 7, 2020
fwyzard added a commit that referenced this pull request Oct 8, 2020
fwyzard added a commit that referenced this pull request Oct 8, 2020
fwyzard added a commit that referenced this pull request Oct 19, 2020
fwyzard added a commit that referenced this pull request Oct 20, 2020
fwyzard added a commit that referenced this pull request Oct 20, 2020
fwyzard added a commit that referenced this pull request Oct 20, 2020
fwyzard added a commit that referenced this pull request Oct 23, 2020
fwyzard added a commit that referenced this pull request Oct 23, 2020
fwyzard added a commit that referenced this pull request Nov 6, 2020
fwyzard added a commit that referenced this pull request Nov 6, 2020
fwyzard added a commit that referenced this pull request Nov 6, 2020
fwyzard added a commit that referenced this pull request Nov 16, 2020
fwyzard added a commit that referenced this pull request Nov 16, 2020
fwyzard added a commit that referenced this pull request Nov 27, 2020
fwyzard added a commit that referenced this pull request Nov 27, 2020
fwyzard added a commit that referenced this pull request Nov 28, 2020
fwyzard pushed a commit that referenced this pull request Dec 25, 2020
fwyzard pushed a commit that referenced this pull request Dec 26, 2020
fwyzard added a commit that referenced this pull request Dec 26, 2020
fwyzard added a commit that referenced this pull request Dec 29, 2020
fwyzard added a commit that referenced this pull request Dec 29, 2020
fwyzard added a commit that referenced this pull request Dec 29, 2020
fwyzard pushed a commit that referenced this pull request Jan 13, 2021
fwyzard added a commit that referenced this pull request Jan 15, 2021
fwyzard added a commit that referenced this pull request Jan 15, 2021
fwyzard added a commit that referenced this pull request Mar 23, 2021
fwyzard added a commit that referenced this pull request Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants