Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up CAHitNtupletHeterogeneousEDProducer #83

Merged
merged 1 commit into from
Jun 18, 2018
Merged

Clean up CAHitNtupletHeterogeneousEDProducer #83

merged 1 commit into from
Jun 18, 2018

Conversation

fwyzard
Copy link

@fwyzard fwyzard commented Jun 18, 2018

Apply some clean up to the code and formatting of CAHitNtupletHeterogeneousEDProducer and CAHitQuadrupletGeneratorGPU, as suggested by @makortel during the review of #48:

  • clean up the BuildFile.xml
  • remove unused data members and arguments from function calls;
  • percolate the CUDA stream instead of storing it as a data member.

Also:

  • add cudaCheck calls around memory allocations and copies;
  • reduce the number of memory allocations used to set up the GPU state.

@fwyzard
Clean up CAHitNtupletHeterogeneousEDProducer
fa990d7 
Apply some clean up to the code and formatting, as suggested by
@makortel during the review of cms-sw#48.

Add `cudaCheck` calls around memory allocations and copies.

Remove unused data members and arguments from function calls.

Reduce the number of memory allocations used to set up the GPU state.

Percolate the CUDA stream instead of storing it as a data member.
@cmsbot
Copy link

cmsbot commented Jun 18, 2018

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_10_2_X_Patatrack.

It involves the following packages:

RecoPixelVertexing/PixelTriplets

@cmsbot, @fwyzard can you please review it and eventually sign? Thanks.

cms-bot commands are listed here

@fwyzard fwyzard mentioned this pull request Jun 18, 2018
Merged
@makortel
Copy link

Looks good, thanks!

@fwyzard
Copy link
Author

fwyzard commented Jun 18, 2018

Validation summary

Reference release CMSSW_10_2_0_pre5 at 30c7b03
Development branch CMSSW_10_2_X_Patatrack at 96559f3
Testing PRs:

makeTrackValidationPlots.py plots

/RelValTTbar_13/CMSSW_10_2_0_pre3-PU25ns_101X_upgrade2018_realistic_v7-v1/GEN-SIM-DIGI-RAW

/RelValZMM_13/CMSSW_10_2_0_pre3-101X_upgrade2018_realistic_v7-v1/GEN-SIM-DIGI-RAW

DQM GUI plots

/RelValTTbar_13/CMSSW_10_2_0_pre3-PU25ns_101X_upgrade2018_realistic_v7-v1/GEN-SIM-DIGI-RAW

  • reference DQM plots for reference release, workflow 10824.5
  • DQM plots for development release, workflow 10824.5
  • DQM plots for development release, workflow 10824.8
  • DQM plots for development release, workflow 10824.7
  • DQM plots for development release, workflow 10824.9 are missing
  • DQM plots for testing release, workflow 10824.5
  • DQM plots for testing release, workflow 10824.8
  • DQM plots for testing release, workflow 10824.7
  • DQM plots for testing release, workflow 10824.9 are missing
  • DQM comparison for reference workflow 10824.5
  • DQM comparison for workflow 10824.8
  • DQM comparison for workflow 10824.7
  • DQM comparison for workflow 10824.9

/RelValZMM_13/CMSSW_10_2_0_pre3-101X_upgrade2018_realistic_v7-v1/GEN-SIM-DIGI-RAW

  • reference DQM plots for reference release, workflow 10824.5
  • DQM plots for development release, workflow 10824.5
  • DQM plots for development release, workflow 10824.8 are missing
  • DQM plots for development release, workflow 10824.7
  • DQM plots for development release, workflow 10824.9 are missing
  • DQM plots for testing release, workflow 10824.5
  • DQM plots for testing release, workflow 10824.8 are missing
  • DQM plots for testing release, workflow 10824.7
  • DQM plots for testing release, workflow 10824.9 are missing
  • DQM comparison for reference workflow 10824.5
  • DQM comparison for workflow 10824.8
  • DQM comparison for workflow 10824.7
  • DQM comparison for workflow 10824.9

logs and nvprof/nvvp profiles

/RelValTTbar_13/CMSSW_10_2_0_pre3-PU25ns_101X_upgrade2018_realistic_v7-v1/GEN-SIM-DIGI-RAW

/RelValZMM_13/CMSSW_10_2_0_pre3-101X_upgrade2018_realistic_v7-v1/GEN-SIM-DIGI-RAW

Logs

The full log is available at https://fwyzard.web.cern.ch/fwyzard/patatrack/pulls/b92fcaf17a9651a6dedf152efddbc56f09a4a89e/log .

@fwyzard
Copy link
Author

fwyzard commented Jun 18, 2018

There are some unexpeted changes in the TTbar workflow - is it possible that we introduced some non-reproducibility at some point ?

Pixel tracks development-10824.5 development-10824.8 testing-10824.8
Efficiency 0.6351 0.6400 0.6408
Number of TrackingParticles (after cuts) 5456 5456 5456
Number of matched TrackingParticles 3465 3492 3496
Fake rate 0.0416 0.0482 0.0483
Duplicate rate 0.0496 0.0456 0.0452
Number of tracks 41541 42633 42627
Number of true tracks 39811 40577 40566
Number of fake tracks 1730 2056 2061
Number of pileup tracks 35054 35756 35748
Number of duplicate tracks 2059 1944 1928

And the Zmumu workflow sorely needs attention :-(

...
Begin processing the 110th record. Run 1, Event 15244, LumiSection 153 on stream 0 at 18-Jun-2018 13:08:11.764 CEST
Begin processing the 111th record. Run 1, Event 15235, LumiSection 153 on stream 0 at 18-Jun-2018 13:08:11.796 CEST
Begin processing the 112th record. Run 1, Event 15237, LumiSection 153 on stream 0 at 18-Jun-2018 13:08:11.840 CEST
======== Error: Application received signal 139

@makortel
Copy link

Interesting. Could you try again (just to see that the third column changes)?

Maybe we need a specific debugging round soon.

@fwyzard
Copy link
Author

fwyzard commented Jun 18, 2018

Validation summary

Reference release CMSSW_10_2_0_pre5 at 30c7b03
Development branch CMSSW_10_2_X_Patatrack at 96559f3
Testing PRs:

makeTrackValidationPlots.py plots

/RelValTTbar_13/CMSSW_10_2_0_pre3-PU25ns_101X_upgrade2018_realistic_v7-v1/GEN-SIM-DIGI-RAW

/RelValZMM_13/CMSSW_10_2_0_pre3-101X_upgrade2018_realistic_v7-v1/GEN-SIM-DIGI-RAW

DQM GUI plots

/RelValTTbar_13/CMSSW_10_2_0_pre3-PU25ns_101X_upgrade2018_realistic_v7-v1/GEN-SIM-DIGI-RAW

  • reference DQM plots for reference release, workflow 10824.5
  • DQM plots for development release, workflow 10824.5
  • DQM plots for development release, workflow 10824.8
  • DQM plots for development release, workflow 10824.7
  • DQM plots for development release, workflow 10824.9 are missing
  • DQM plots for testing release, workflow 10824.5
  • DQM plots for testing release, workflow 10824.8
  • DQM plots for testing release, workflow 10824.7
  • DQM plots for testing release, workflow 10824.9 are missing
  • DQM comparison for reference workflow 10824.5
  • DQM comparison for workflow 10824.8
  • DQM comparison for workflow 10824.7
  • DQM comparison for workflow 10824.9

/RelValZMM_13/CMSSW_10_2_0_pre3-101X_upgrade2018_realistic_v7-v1/GEN-SIM-DIGI-RAW

  • reference DQM plots for reference release, workflow 10824.5
  • DQM plots for development release, workflow 10824.5
  • DQM plots for development release, workflow 10824.8 are missing
  • DQM plots for development release, workflow 10824.7
  • DQM plots for development release, workflow 10824.9 are missing
  • DQM plots for testing release, workflow 10824.5
  • DQM plots for testing release, workflow 10824.8 are missing
  • DQM plots for testing release, workflow 10824.7
  • DQM plots for testing release, workflow 10824.9 are missing
  • DQM comparison for reference workflow 10824.5
  • DQM comparison for workflow 10824.8
  • DQM comparison for workflow 10824.7
  • DQM comparison for workflow 10824.9

logs and nvprof/nvvp profiles

/RelValTTbar_13/CMSSW_10_2_0_pre3-PU25ns_101X_upgrade2018_realistic_v7-v1/GEN-SIM-DIGI-RAW

/RelValZMM_13/CMSSW_10_2_0_pre3-101X_upgrade2018_realistic_v7-v1/GEN-SIM-DIGI-RAW

Logs

The full log is available at https://fwyzard.web.cern.ch/fwyzard/patatrack/pulls/cd6a3b17d44c03deb2263fb926f9018907651236/log .

@fwyzard
Copy link
Author

fwyzard commented Jun 18, 2018

Indeed, the non-reproducibility is already present:

Pixel tracks development-10824.5 development-10824.8 testing-10824.8
Efficiency 0.6351 0.6408 0.6404
Number of TrackingParticles (after cuts) 5456 5456 5456
Number of matched TrackingParticles 3465 3496 3494
Fake rate 0.0416 0.0483 0.0484
Duplicate rate 0.0496 0.0456 0.0448
Number of tracks 41541 42624 42626
Number of true tracks 39811 40567 40561
Number of fake tracks 1730 2057 2065
Number of pileup tracks 35054 35747 35741
Number of duplicate tracks 2059 1942 1911

@fwyzard fwyzard merged commit bcee919 into cms-patatrack:CMSSW_10_2_X_Patatrack Jun 18, 2018
@makortel makortel mentioned this pull request Jun 18, 2018
Closed
@makortel
Copy link

I created an issue #84 to for the irreproducibility and crash.

@fwyzard fwyzard deleted the Clean_up_CAHitNtupletHeterogeneousEDProducer branch June 26, 2018 09:18
@fwyzard fwyzard added this to the CMSSW_10_2_0_pre6_Patatrack milestone Jul 5, 2018
fwyzard pushed a commit that referenced this pull request Nov 1, 2018
@mbluj
Merge pull request #83 from steggema/TauClusterVarRefactorPlusTemplat…
43fbbdd 
…e_10_3_X

Tau cluster variable refactoring: Avoid code duplication
fwyzard added a commit that referenced this pull request Oct 8, 2020
@fwyzard
Clean up CAHitNtupletHeterogeneousEDProducer (#83)
3b9821f 
Apply some clean up to the code and formatting of `CAHitNtupletHeterogeneousEDProducer` and `CAHitQuadrupletGeneratorGPU`, as suggested by @makortel during the review of #48:
  - clean up the `BuildFile.xml`
  - remove unused data members and arguments from function calls;
  - percolate the CUDA stream instead of storing it as a data member.

Also:
  - add `cudaCheck` calls around memory allocations and copies;
  - reduce the number of memory allocations used to set up the GPU state.
@fwyzard fwyzard mentioned this pull request Oct 8, 2020
Merged
fwyzard added a commit that referenced this pull request Oct 20, 2020
@fwyzard
Clean up CAHitNtupletHeterogeneousEDProducer (#83)
9c31f02 
Apply some clean up to the code and formatting of `CAHitNtupletHeterogeneousEDProducer` and `CAHitQuadrupletGeneratorGPU`, as suggested by @makortel during the review of #48:
  - clean up the `BuildFile.xml`
  - remove unused data members and arguments from function calls;
  - percolate the CUDA stream instead of storing it as a data member.

Also:
  - add `cudaCheck` calls around memory allocations and copies;
  - reduce the number of memory allocations used to set up the GPU state.
fwyzard added a commit that referenced this pull request Oct 20, 2020
@fwyzard
Clean up CAHitNtupletHeterogeneousEDProducer (#83)
453a4b2 
Apply some clean up to the code and formatting of `CAHitNtupletHeterogeneousEDProducer` and `CAHitQuadrupletGeneratorGPU`, as suggested by @makortel during the review of #48:
  - clean up the `BuildFile.xml`
  - remove unused data members and arguments from function calls;
  - percolate the CUDA stream instead of storing it as a data member.

Also:
  - add `cudaCheck` calls around memory allocations and copies;
  - reduce the number of memory allocations used to set up the GPU state.
fwyzard added a commit that referenced this pull request Oct 23, 2020
@fwyzard
Clean up CAHitNtupletHeterogeneousEDProducer (#83)
00ceb32 
Apply some clean up to the code and formatting of `CAHitNtupletHeterogeneousEDProducer` and `CAHitQuadrupletGeneratorGPU`, as suggested by @makortel during the review of #48:
  - clean up the `BuildFile.xml`
  - remove unused data members and arguments from function calls;
  - percolate the CUDA stream instead of storing it as a data member.

Also:
  - add `cudaCheck` calls around memory allocations and copies;
  - reduce the number of memory allocations used to set up the GPU state.
fwyzard added a commit that referenced this pull request Nov 6, 2020
@fwyzard
Clean up CAHitNtupletHeterogeneousEDProducer (#83)
714d2cf 
Apply some clean up to the code and formatting of `CAHitNtupletHeterogeneousEDProducer` and `CAHitQuadrupletGeneratorGPU`, as suggested by @makortel during the review of #48:
  - clean up the `BuildFile.xml`
  - remove unused data members and arguments from function calls;
  - percolate the CUDA stream instead of storing it as a data member.

Also:
  - add `cudaCheck` calls around memory allocations and copies;
  - reduce the number of memory allocations used to set up the GPU state.
fwyzard added a commit that referenced this pull request Nov 6, 2020
@fwyzard
Clean up CAHitNtupletHeterogeneousEDProducer (#83)
dc5b75f 
Apply some clean up to the code and formatting of `CAHitNtupletHeterogeneousEDProducer` and `CAHitQuadrupletGeneratorGPU`, as suggested by @makortel during the review of #48:
  - clean up the `BuildFile.xml`
  - remove unused data members and arguments from function calls;
  - percolate the CUDA stream instead of storing it as a data member.

Also:
  - add `cudaCheck` calls around memory allocations and copies;
  - reduce the number of memory allocations used to set up the GPU state.
fwyzard added a commit that referenced this pull request Nov 16, 2020
@fwyzard
Clean up CAHitNtupletHeterogeneousEDProducer (#83)
11b7908 
Apply some clean up to the code and formatting of `CAHitNtupletHeterogeneousEDProducer` and `CAHitQuadrupletGeneratorGPU`, as suggested by @makortel during the review of #48:
  - clean up the `BuildFile.xml`
  - remove unused data members and arguments from function calls;
  - percolate the CUDA stream instead of storing it as a data member.

Also:
  - add `cudaCheck` calls around memory allocations and copies;
  - reduce the number of memory allocations used to set up the GPU state.
fwyzard added a commit that referenced this pull request Nov 27, 2020
@fwyzard
Clean up CAHitNtupletHeterogeneousEDProducer (#83)
7b1f86d 
Apply some clean up to the code and formatting of `CAHitNtupletHeterogeneousEDProducer` and `CAHitQuadrupletGeneratorGPU`, as suggested by @makortel during the review of #48:
  - clean up the `BuildFile.xml`
  - remove unused data members and arguments from function calls;
  - percolate the CUDA stream instead of storing it as a data member.

Also:
  - add `cudaCheck` calls around memory allocations and copies;
  - reduce the number of memory allocations used to set up the GPU state.
fwyzard pushed a commit that referenced this pull request Dec 26, 2020
@cmsbuild @fwyzard
Clean up CAHitNtupletHeterogeneousEDProducer (#83)
c264353 
Apply some clean up to the code and formatting of `CAHitNtupletHeterogeneousEDProducer` and `CAHitQuadrupletGeneratorGPU`, as suggested by @makortel during the review of #48:
  - clean up the `BuildFile.xml`
  - remove unused data members and arguments from function calls;
  - percolate the CUDA stream instead of storing it as a data member.

Also:
  - add `cudaCheck` calls around memory allocations and copies;
  - reduce the number of memory allocations used to set up the GPU state.
@fwyzard fwyzard mentioned this pull request Dec 26, 2020
Merged
fwyzard added a commit that referenced this pull request Jan 15, 2021
@fwyzard
Clean up CAHitNtupletHeterogeneousEDProducer (#83)
ba46ad5 
Apply some clean up to the code and formatting of `CAHitNtupletHeterogeneousEDProducer` and `CAHitQuadrupletGeneratorGPU`, as suggested by @makortel during the review of #48:
  - clean up the `BuildFile.xml`
  - remove unused data members and arguments from function calls;
  - percolate the CUDA stream instead of storing it as a data member.

Also:
  - add `cudaCheck` calls around memory allocations and copies;
  - reduce the number of memory allocations used to set up the GPU state.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
CMSSW_10_2_0_pre6_Patatrack
Development

Successfully merging this pull request may close these issues.
3 participants
@fwyzard @cmsbot @makortel