Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't merge - release used for CTD19 #291

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
129 commits
Select commit Hold shift + click to select a range
4973ac7
Add back standalone GPU fit test
rovere Sep 3, 2018
5e21c6b
First Broken Line import
GimmyTomas Sep 3, 2018
56ab682
Merged PatatrackHackathon4 from repository rovere with cms-merge-topic
GimmyTomas Sep 3, 2018
d447fbb
BrokenLineGPU: work in progress
GimmyTomas Sep 4, 2018
55a86bc
Full implementation of the broken line fit. For the moment it needs m…
GimmyTomas Sep 19, 2018
d864079
Full implementation of the broken line fit. For the moment it needs t…
GimmyTomas Sep 19, 2018
e29cb32
Fixed the requested changes:
GimmyTomas Sep 20, 2018
7557d8d
Just forgot to add the files for the broken line modifier.
GimmyTomas Sep 20, 2018
9b81f01
DO NOT MERGE - reuse the 10824.7 and .9 workflows to test the broken …
fwyzard Sep 20, 2018
174a6cc
Replaced by the autogenerated cfi file
fwyzard Sep 20, 2018
ce31f94
Merge branch 'CMSSW_10_2_X_Patatrack' into broken_line_fit
fwyzard Sep 25, 2018
e8faf5d
Merge branch 'CMSSW_10_2_X_Patatrack' into broken_line_fit
fwyzard Nov 9, 2018
a25628f
fix conflicts
VinInn Jan 29, 2019
fefb9cb
Merged broken_line_fit from repository VinInn with cms-merge-topic
VinInn Jan 29, 2019
7f731ad
fix matrix init
VinInn Jan 29, 2019
e8207e6
make it working
VinInn Jan 30, 2019
a3950ea
make it working
VinInn Jan 30, 2019
8578b61
tests runs
VinInn Jan 30, 2019
36550f2
some previous clenup
VinInn Jan 30, 2019
790ccfa
change name of fit driver
VinInn Jan 30, 2019
11482bf
BL driver ok
VinInn Jan 31, 2019
91eeafd
trivial if
VinInn Jan 31, 2019
7f0f80c
make BL default
VinInn Jan 31, 2019
92b33eb
Merged broken_line_fit from repository VinInn with cms-merge-topic
VinInn Jan 31, 2019
2013a29
allow dump of hits
VinInn Feb 3, 2019
cbc4064
Merged OptFitting105 from repository VinInn with cms-merge-topic
VinInn Feb 3, 2019
cc68930
inversion by Cholesky Decomposition
VinInn Feb 3, 2019
9dbd97c
use cholesky invert, enable 3,4,5 hit fit
VinInn Feb 4, 2019
ce8f8e1
Merged OptFitting105 from repository VinInn with cms-merge-topic
VinInn Feb 4, 2019
ad060c9
remove sqrt from choleshy
VinInn Feb 5, 2019
fce5dab
Merged OptFitting105 from repository VinInn with cms-merge-topic
VinInn Feb 5, 2019
e7fc479
cleanup cpu workflows with Rimann or BrokenLine
VinInn Feb 5, 2019
7b7dd7b
cleanup cpu workflows with Rimann or BrokenLine
VinInn Feb 5, 2019
5b9e9e6
change name to workflows as well
VinInn Feb 5, 2019
e0ebdfe
apply Matti's suggestions
VinInn Feb 6, 2019
ef1387a
try to use triplets in hole
VinInn Feb 6, 2019
bf9e9ee
pass triplets to verfication
VinInn Feb 6, 2019
c1f7483
get nutple multiplicity
VinInn Feb 7, 2019
d0f0ff2
fits3,4 and 5
VinInn Feb 7, 2019
acef030
fit 5 as 4
VinInn Feb 7, 2019
28e3e65
also rienmann 3,4&5
VinInn Feb 7, 2019
05c3527
riemann 5 as 4 as well
VinInn Feb 7, 2019
b8c7529
add configurables
VinInn Feb 8, 2019
c40436c
fix printout
VinInn Feb 8, 2019
476cb5a
Merged TripletsInHole from repository VinInn with cms-merge-topic
VinInn Feb 9, 2019
cb2ffbd
remove debug
VinInn Feb 9, 2019
447ee59
Merged TripletsInHole from repository VinInn with cms-merge-topic
VinInn Feb 10, 2019
7ea5f28
add ability to count locally
VinInn Feb 10, 2019
294a447
use local counters
VinInn Feb 10, 2019
0048368
Merged TripletsInHole from repository VinInn with cms-merge-topic
VinInn Feb 10, 2019
e9dee7b
update local for real
VinInn Feb 10, 2019
8b8a4c8
Merged TripletsInHole from repository VinInn with cms-merge-topic
VinInn Feb 10, 2019
7274328
avoid early return
VinInn Feb 10, 2019
9360613
Merged TripletsInHole from repository VinInn with cms-merge-topic
VinInn Feb 10, 2019
5dd17cc
back to global
VinInn Feb 11, 2019
d80fe12
Merged TripletsInHole from repository VinInn with cms-merge-topic
VinInn Feb 11, 2019
9aafe7c
on gpu works
VinInn Feb 14, 2019
61361ec
compiles
VinInn Feb 14, 2019
10253aa
compiles
VinInn Feb 14, 2019
24065d7
fix thread local init
VinInn Feb 14, 2019
b2f779a
san tommaso
VinInn Feb 14, 2019
583f1e6
run on gpu & cpu
VinInn Feb 14, 2019
8e5191d
Merged cudaCompat from repository VinInn with cms-merge-topic
VinInn Feb 15, 2019
c0a3d22
seems working
VinInn Feb 15, 2019
dafcac8
cpu and gpu same
VinInn Feb 15, 2019
fb702cc
cpu and gpu same
VinInn Feb 15, 2019
d1e8e80
add two alternative (faster) track clusterizers
VinInn Feb 15, 2019
ee73282
make it working on cpu as well
VinInn Feb 15, 2019
4097c6d
spit workspace
VinInn Feb 17, 2019
be30ac4
Merged cudaCompat from repository VinInn with cms-merge-topic
VinInn Feb 18, 2019
1b3c093
implement Matti's suggestions
VinInn Feb 19, 2019
36834df
assert cuda emulation
VinInn Feb 19, 2019
ddb6419
fix missing free and add _
VinInn Feb 19, 2019
9f06db8
add clus size
VinInn Feb 25, 2019
f6452bd
apply zsize cut at doublets
VinInn Feb 25, 2019
b1a4522
Merged gpuClusSize from repository VinInn with cms-merge-topic
VinInn Feb 25, 2019
a12d3ae
mitigate broken clus
VinInn Feb 25, 2019
b753073
Merged gpuClusSize from repository VinInn with cms-merge-topic
VinInn Feb 25, 2019
b345b9d
try larger cut on b1
VinInn Feb 25, 2019
8fd3c6b
Merged gpuClusSize from repository VinInn with cms-merge-topic
VinInn Feb 25, 2019
97b6a46
try larger cut on b1
VinInn Feb 25, 2019
9a713d1
Merged gpuClusSize from repository VinInn with cms-merge-topic
VinInn Feb 25, 2019
9cddb3b
introduce z cut
VinInn Feb 26, 2019
d49dafc
Merged gpuClusSize from repository VinInn with cms-merge-topic
VinInn Feb 26, 2019
e4aa589
debugging tp assoc on gpu
VinInn Feb 26, 2019
c06d565
fix parentesis after not
VinInn Feb 27, 2019
aebdf9a
enable clus size cut
VinInn Feb 27, 2019
b8168da
add conters
VinInn Feb 27, 2019
07d8001
add clus size cut on B1
VinInn Feb 27, 2019
4122a8d
Merged gpuClusSize from repository VinInn with cms-merge-topic
VinInn Feb 27, 2019
43110c7
add good track counter
VinInn Feb 27, 2019
d9ec193
Merged gpuClusSize from repository VinInn with cms-merge-topic
VinInn Feb 27, 2019
db23080
add possibility to test full doublet combinatorics
VinInn Feb 28, 2019
ed02737
new default
VinInn Feb 28, 2019
cb7496a
soft b1-only-Outer
VinInn Mar 1, 2019
429b434
no size cut in B1inner at all
VinInn Mar 1, 2019
631b6b1
no size cut in B1inner at all
VinInn Mar 1, 2019
c0a44bb
cut on B2 clean
VinInn Mar 4, 2019
f3cdceb
ideal setting
VinInn Mar 9, 2019
29b3e94
allow all triplets, protect vertex from triplets
VinInn Mar 9, 2019
73e1644
separate zcut form clsize
VinInn Mar 10, 2019
df9ab83
cleanup
VinInn Mar 10, 2019
9c4e855
make cuts configurables
VinInn Mar 10, 2019
4adf830
port to pre2
VinInn Mar 10, 2019
1c4654c
Merged gpuClusSizeReloaded from repository VinInn with cms-merge-topic
VinInn Mar 10, 2019
33f4e12
make default with no ifdef, new notebook
VinInn Mar 10, 2019
de8a395
for release remove counter output
VinInn Mar 10, 2019
e1f6196
add dump of zo,ro
VinInn Mar 12, 2019
27f8bb4
add dump of zo,ro
VinInn Mar 12, 2019
cacd3a5
new notebook with z0 resolution
VinInn Mar 12, 2019
4ed7314
no cluster shape cut
VinInn Mar 13, 2019
dd7853a
fix long standing issue with tracks not on cpu
VinInn Mar 13, 2019
578089a
back clus size cut
VinInn Mar 13, 2019
b8ab753
Merge branch 'CMSSW_10_5_X_Patatrack' into gpuClusSizeReloaded
VinInn Mar 13, 2019
204088f
Merge branch 'CMSSW_10_5_X_Patatrack' into gpuClusSizeReloaded
felicepantaleo Mar 15, 2019
c931c62
Merged refs/pull/276/head from repository cms-patatrack with cms-merg…
felicepantaleo Mar 18, 2019
fee89bf
loosening of the TIP cut from 1mm to 5mm
felicepantaleo Mar 18, 2019
c9bffce
Merged gpuClusSizeReloaded from repository VinInn with cms-merge-topic
VinInn Mar 21, 2019
ce28b57
limit pt in MS and remove a sqrt
VinInn Mar 18, 2019
0fb8530
fix chi2 in riemann
VinInn Mar 20, 2019
29bdf79
remove comment
VinInn Mar 21, 2019
d02b6b9
apply chi2 cut as function of pt
VinInn Mar 19, 2019
46523ba
move tip cut to 5mm
VinInn Mar 21, 2019
0ce22da
tune AlignedRZ in barrel
VinInn Mar 19, 2019
8ca8b5d
make theta cut in the barrel stricter
VinInn Mar 21, 2019
2f1194d
Merged refs/pull/291/head from repository cms-patatrack with cms-merg…
felicepantaleo Mar 21, 2019
3b24e4f
Merged refs/pull/295/head from repository cms-patatrack with cms-merg…
felicepantaleo Mar 22, 2019
79b793a
fix merge conflict
felicepantaleo Mar 22, 2019
93f056b
fix merge conflict
felicepantaleo Apr 17, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import FWCore.ParameterSet.Config as cms

# This modifier is for replacing the default pixel track "fitting" with Riemann fit on GPU
# This modifier is for replacing the default pixel track "fitting" with eihter Riemann or BrokenLine fit

riemannFitGPU = cms.Modifier()
pixelNtupleFit = cms.Modifier()
5 changes: 0 additions & 5 deletions Configuration/ProcessModifiers/python/riemannFit_cff.py

This file was deleted.

18 changes: 5 additions & 13 deletions Configuration/PyReleaseValidation/python/relval_steps.py
Original file line number Diff line number Diff line change
Expand Up @@ -2047,11 +2047,8 @@ def gen2018HiMix(fragment,howMuch):
'--datatier': 'GEN-SIM-RECO,DQMIO',
'--eventcontent': 'RECOSIM,DQM',
}
step3_riemannFit = {
'--procModifiers': 'riemannFit',
}
step3_riemannFitGPU = {
'--procModifiers': 'riemannFitGPU',
step3_pixelNtupleFit = {
'--procModifiers': 'pixelNtupleFit',
}
step3_gpu = {
'--procModifiers': 'gpu',
Expand Down Expand Up @@ -3136,14 +3133,9 @@ def gen2018HiMix(fragment,howMuch):
if 'Reco' in step: upgradeStepDict[stepName][k] = merge([step3_pixelTrackingOnly, upgradeStepDict[step][k]])
elif 'HARVEST' in step: upgradeStepDict[stepName][k] = merge([{'-s': 'HARVESTING:@trackingOnlyValidation+@pixelTrackingOnlyDQM'}, upgradeStepDict[step][k]])

for step in upgradeSteps['pixelTrackingOnlyRiemannFit']['steps']:
stepName = step + upgradeSteps['pixelTrackingOnlyRiemannFit']['suffix']
if 'Reco' in step: upgradeStepDict[stepName][k] = merge([step3_riemannFit, step3_pixelTrackingOnly, upgradeStepDict[step][k]])
elif 'HARVEST' in step: upgradeStepDict[stepName][k] = merge([{'-s': 'HARVESTING:@trackingOnlyValidation+@pixelTrackingOnlyDQM'}, upgradeStepDict[step][k]])

for step in upgradeSteps['pixelTrackingOnlyRiemannFitGPU']['steps']:
stepName = step + upgradeSteps['pixelTrackingOnlyRiemannFitGPU']['suffix']
if 'Reco' in step: upgradeStepDict[stepName][k] = merge([step3_riemannFitGPU, step3_pixelTrackingOnly, upgradeStepDict[step][k]])
for step in upgradeSteps['pixelTrackingOnlyNtupleFit']['steps']:
stepName = step + upgradeSteps['pixelTrackingOnlyNtupleFit']['suffix']
if 'Reco' in step: upgradeStepDict[stepName][k] = merge([step3_pixelNtupleFit, step3_pixelTrackingOnly, upgradeStepDict[step][k]])
elif 'HARVEST' in step: upgradeStepDict[stepName][k] = merge([{'-s': 'HARVESTING:@trackingOnlyValidation+@pixelTrackingOnlyDQM'}, upgradeStepDict[step][k]])

for step in upgradeSteps['pixelTrackingOnlyGPU']['steps']:
Expand Down
2 changes: 1 addition & 1 deletion Configuration/PyReleaseValidation/python/relval_upgrade.py
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ def makeStepName(key,frag,step,suffix):
# special workflows for tracker
if (upgradeDatasetFromFragment[frag]=="TTbar_13" or upgradeDatasetFromFragment[frag]=="TTbar_14TeV") and not 'PU' in key and hasHarvest:
# skip ALCA and Nano
trackingVariations = ['trackingOnly','trackingRun2','trackingOnlyRun2','trackingLowPU','pixelTrackingOnly','pixelTrackingOnlyRiemannFit','pixelTrackingOnlyRiemannFitGPU','pixelTrackingOnlyGPU']
trackingVariations = ['trackingOnly','trackingRun2','trackingOnlyRun2','trackingLowPU','pixelTrackingOnly','pixelTrackingOnlyNtupleFit','pixelTrackingOnlyGPU']
for tv in trackingVariations:
stepList[tv] = [s for s in stepList[tv] if (("ALCA" not in s) and ("Nano" not in s))]
workflows[numWF+upgradeSteps['trackingOnly']['offset']] = [ upgradeDatasetFromFragment[frag], stepList['trackingOnly']]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -158,15 +158,15 @@
'suffix' : '_pixelTrackingOnly',
'offset' : 0.5,
}
upgradeSteps['pixelTrackingOnlyRiemannFit'] = {
upgradeSteps['pixelTrackingOnlyNtupleFit'] = {
'steps' : [
'RecoFull',
'HARVESTFull',
'RecoFullGlobal',
'HARVESTFullGlobal',
],
'PU' : [],
'suffix' : '_pixelTrackingOnlyRiemannFit',
'suffix' : '_pixelTrackingOnlyNtupleFit',
'offset' : 0.51,
}
upgradeSteps['pixelTrackingOnlyGPU'] = {
Expand All @@ -180,17 +180,6 @@
'suffix' : '_pixelTrackingOnlyGPU',
'offset' : 0.52,
}
upgradeSteps['pixelTrackingOnlyRiemannFitGPU'] = {
'steps' : [
'RecoFull',
'HARVESTFull',
'RecoFullGlobal',
'HARVESTFullGlobal',
],
'PU' : [],
'suffix' : '_pixelTrackingOnlyRiemannFitGPU',
'offset' : 0.53,
}
upgradeSteps['Timing'] = {
'steps' : upgradeSteps['baseline']['steps'],
'PU' : upgradeSteps['baseline']['PU'],
Expand Down
1 change: 1 addition & 0 deletions DataFormats/Math/BuildFile.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<use name="DataFormats/Common"/>
<use name="rootmath"/>
<use name="eigen"/>

<export>
<lib name="1"/>
Expand Down
Loading