don't merge - release used for CTD19 #291
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atrices of static dimensions to run on the GPUs
…o use matrices of static dimensions in order to run on the GPUs.
- deleted the forgotten prints and time measurements; - created a new modifier for the broken line fit; - switched back from tipMax=1 to tipMax=0.1 (the change will maybe be done in another PR); - restored the original order of the cuts on chi2 and tip; - deleted the default label to pixelFitterByBrokenLine; - switched from CUDA_HOSTDEV to __host__ __device__; - BrokenLine.h now uses dinamically-sized-matrices (the advantage in using them over the statically-sized ones is that the code would also work with n>4) and, as before, the switch can be easily done at the start of the file; - hence, the test on GPUs now needs an increase in the stack size (at least 1761 bytes); - some doxygen comments in BrokenLine.h have been updated.
felicepantaleo
force-pushed
the
CTD2019_10_5_0_pre2_Patatrack
branch
from
09ea212
to
fee89bf
Compare
fwyzard
added a commit
that referenced
this pull request
Mar 29, 2019
fwyzard
added a commit
that referenced
this pull request
Mar 29, 2019
|
I've merged this on top of |
|
Note: for the Riemann fit workflow, an additional change is needed: diff --git a/RecoPixelVertexing/PixelTriplets/plugins/CAHitQuadrupletGeneratorKernels.cu b/RecoPixelVertexing/PixelTriplets/plugins/CAHitQuadrupletGeneratorKernels.cu
index 166893ed9f5..959a910dbae 100644
--- a/RecoPixelVertexing/PixelTriplets/plugins/CAHitQuadrupletGeneratorKernels.cu
+++ b/RecoPixelVertexing/PixelTriplets/plugins/CAHitQuadrupletGeneratorKernels.cu
@@ -256,7 +256,7 @@ void kernel_VerifyFit(TuplesOnGPU::Container const * __restrict__ tuples,
}
const float par[4] = {0.68177776, 0.74609577, -0.08035491, 0.00315399};
- constexpr float chi2CutFact = 30; // *0.7 if Riemann....
+ constexpr float chi2CutFact = 45; // 45 if Riemann....
auto chi2Cut = [&](float pt) {
pt = std::min(pt,10.f);
return chi2CutFact*(par[0]+pt*(par[1]+pt*(par[2]+pt*par[3]))); |
15 tasks
felicepantaleo
changed the base branch from
CMSSW_10_5_X_Patatrack
to
CMSSW_10_6_X_Patatrack
|
I guess this is no longer the "release used for CTD19" ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.