CTD19 developments for review and merging #324
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atrices of static dimensions to run on the GPUs
…o use matrices of static dimensions in order to run on the GPUs.
- deleted the forgotten prints and time measurements; - created a new modifier for the broken line fit; - switched back from tipMax=1 to tipMax=0.1 (the change will maybe be done in another PR); - restored the original order of the cuts on chi2 and tip; - deleted the default label to pixelFitterByBrokenLine; - switched from CUDA_HOSTDEV to __host__ __device__; - BrokenLine.h now uses dinamically-sized-matrices (the advantage in using them over the statically-sized ones is that the code would also work with n>4) and, as before, the switch can be easily done at the start of the file; - hence, the test on GPUs now needs an increase in the stack size (at least 1761 bytes); - some doxygen comments in BrokenLine.h have been updated.
This was referenced Apr 30, 2019
fwyzard
added a commit
that referenced
this pull request
Apr 30, 2019
|
Superseded by #338. |
fwyzard
pushed a commit
that referenced
this pull request
May 2, 2019
fwyzard
pushed a commit
that referenced
this pull request
May 2, 2019
fwyzard
pushed a commit
that referenced
this pull request
May 2, 2019
fwyzard
pushed a commit
that referenced
this pull request
May 2, 2019
fwyzard
pushed a commit
that referenced
this pull request
May 2, 2019
fwyzard
pushed a commit
that referenced
this pull request
May 2, 2019
fwyzard
pushed a commit
that referenced
this pull request
May 2, 2019
fwyzard
pushed a commit
that referenced
this pull request
May 2, 2019
fwyzard
pushed a commit
that referenced
this pull request
May 3, 2019
fwyzard
pushed a commit
that referenced
this pull request
May 3, 2019
fwyzard
pushed a commit
that referenced
this pull request
May 3, 2019
fwyzard
pushed a commit
that referenced
this pull request
May 3, 2019
fwyzard
pushed a commit
that referenced
this pull request
May 3, 2019
fwyzard
pushed a commit
that referenced
this pull request
May 3, 2019
fwyzard
pushed a commit
that referenced
this pull request
May 8, 2019
fwyzard
pushed a commit
that referenced
this pull request
May 8, 2019
This was referenced May 13, 2019
fwyzard
pushed a commit
that referenced
this pull request
May 15, 2019
Update master to CMSSW_10_6_0_pre4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is basically #291 rebased to the latest CMSSW_10_6_X_Patatrack that @rovere and I are using for review.
I attempted the splitting of the PR in smaller PRs based on packages but did not succeed.