Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up to PR31722 (#614) #615

Closed
wants to merge 14 commits into from
Closed

Follow up to PR31722 (#614) #615

wants to merge 14 commits into from

Commits on Apr 9, 2021

  1. Fixed include guards naming. (cms-sw#614) 

    cms-sw#31722 (review)
    @ericcano
    ericcano committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    3ad9505 View commit details
    Browse the repository at this point in the history

  2. Unified member access methods for class TrackSoAHeterogeneousT. (cms-… 

    …sw#614)

Used accessors in all cases. This commit does not change the memory layout of the class.
Also fixed C-style casts (reinterpret casts are needed here).
cms-sw#31722 (comment)
cms-sw#31722 (comment)
    @ericcano
    ericcano committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    cf8183b View commit details
    Browse the repository at this point in the history

  3. Fixed indlude guards naming. (cms-sw#614) 

    cms-sw#31722 (comment)
    @ericcano
    ericcano committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    bb54a9d View commit details
    Browse the repository at this point in the history

  4. Fixed C-style cast. (cms-sw#614) 

    cms-sw#31722 (comment)
    @ericcano
    ericcano committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    e643961 View commit details
    Browse the repository at this point in the history

  5. Reduced duplicate computations with temporary variables. (cms-sw#614) 

    Also removed addition of transposed matrix by directly copying the needed elements.
cms-sw#31722 (comment)
cms-sw#31722 (comment)
    @ericcano
    ericcano committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    d0f5bb4 View commit details
    Browse the repository at this point in the history

  6. Updated comments after methods renaming. (cms-sw#614) 

    cms-sw#31722 (comment).
    @ericcano
    ericcano committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    a8a0cd6 View commit details
    Browse the repository at this point in the history

  7. Modified PixelTrackProducer class to use esConsume(). (cms-sw#614) 

    cms-sw#31722 (comment)
    @ericcano
    ericcano committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    52c9187 View commit details
    Browse the repository at this point in the history

  8. Minor simplification (cms-sw#614) 

    cms-sw#31722 (comment)
    @ericcano
    ericcano committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    51210ff View commit details
    Browse the repository at this point in the history

  9. Reduced computations with a local variable. 

    Also introduced a computation simplification suggested in:
cms-sw#31722 (comment)
    @ericcano
    ericcano committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    6169335 View commit details
    Browse the repository at this point in the history

  10. Simplified computations. 

    cms-sw#31722 (comment)
cms-sw#31722 (comment)
cms-sw#31722 (comment)
    @ericcano
    ericcano committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    69ce9d5 View commit details
    Browse the repository at this point in the history

  11. Update RecoPixelVertexing/PixelTrackFitting/interface/RiemannFit.h 

    Co-authored-by: Andrea Bocci <andrea.bocci@cern.ch>
    @ericcano @fwyzard
    ericcano and fwyzard committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    96d121f View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2021

  1. Returned complex strcuture by reference instead of value. 

    Also made the type explicit.
cms-patatrack#615 (comment)
    @ericcano
    ericcano committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    17df41c View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2021

  1. Fused class, header and SealModule.cc file. 

    cms-sw#31722 (comment)
    @ericcano
    ericcano committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    733f374 View commit details
    Browse the repository at this point in the history

  2. Removed unneeded range checking. 

    cms-sw#31722 (comment)
cms-sw#31722 (comment)
    @ericcano
    ericcano committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    8cd10d8 View commit details
    Browse the repository at this point in the history