Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process_pr: only trigger automatic tests for first L2 signature #2214

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

iarspider
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for branch master.

@aandvalenzuela, @iarspider, @cmsbuild, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 18, 2024

cms-bot internal usage

@smuzaffar smuzaffar changed the title process_pr: only trigger automatic tests once per PR process_pr: only trigger automatic tests for first L2 signature Apr 18, 2024
@cmsbuild
Copy link
Contributor

Pull request #2214 was updated.

@smuzaffar
Copy link
Contributor

smuzaffar commented Apr 18, 2024

+externals

@iarspider , looks good. By the way, as now auto_test_comment will point to first comment so one side effect will be that if someone adds a comment to PRs, such as cms-sw/cmssw#44735 , then bot will trigger tests (due to https://github.com/cms-sw/cms-bot/blob/master/process_pr.py#L1822-L1826 check as previous test url will not match the new test request url). There might be few such PRs but I guess we can ignore those for now. At least this fix will protect us re-running tests for new PRs.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar
Copy link
Contributor

@missirol , this should fix the issue of re-triggering PR tests ( as we have seen for cms-sw/cmssw#44735 ) with one side effect see #2214 (comment)

@smuzaffar smuzaffar merged commit 32daf3f into master Apr 18, 2024
3 of 4 checks passed
@missirol
Copy link
Contributor

Thank you @smuzaffar !

@iarspider iarspider deleted the fix-autotest branch April 19, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants