-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix PSet of EvFDaqDirector
in convertToRaw.py
#44735
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44735/39953
|
A new Pull Request was created by @missirol for master. It involves the following packages:
@cmsbuild, @Martin-Grunewald, @mmusich can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
type bug-fix |
+hlt |
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24d3ac/38844/summary.html Comparison SummarySummary:
|
+1 |
Mh.. The bot changed a label from |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24d3ac/38859/summary.html Comparison SummarySummary:
|
@missirol , we are looking in to it. |
ping, lets see if bot triggers tests for this ( I think it will after cms-sw/cms-bot#2214 ) |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24d3ac/38928/summary.html Comparison SummarySummary:
|
PR description:
This PR updates
convertToRaw.py
in order to adapt to thefillDescriptions
changes introduced in #43850. The utilityconvertToRaw
does not currently work in14_0_X
and14_1_X
without this change. The change is merely technical: none of the values of the existing parameters are changed. A typo inconvertToRaw
is also fixed.Merely technical. No changes expected.
(It would be good to add a unit test for this utility, but I currently do not have enough time to implement a proper one, and I would not delay this fix.)
FYI: @fwyzard
PR validation:
The test below works in
CMSSW_14_1_0_pre2
only post-PR. For reference, the runtime error pre-PR is copied below.If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:
To be backported to
CMSSW_14_0_X
for trigger studies on 2024 data.