Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update root master #4674

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented Feb 4, 2019

No description provided.

@mrodozov
Copy link
Contributor Author

mrodozov commented Feb 4, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2019

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_10_5_X/rootmaster.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2019

-1

Tested at: 8611efb

  • Build:

I found compilation warning when building: See details on the summary page.

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4674/32980/summary.html

Fix the branch ID
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2019

Pull request #4674 was updated.

@mrodozov
Copy link
Contributor Author

mrodozov commented Feb 4, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2019

-1

Tested at: be42eac

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4674/32983/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test TestFWCoreFrameworkGlobalStreamOne had ERRORS

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2019

-1

Tested at: be42eac

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4674/32995/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test testPhase2PixelNtuple had ERRORS
---> test materialBudgetTrackerPlots had ERRORS
---> test TestPoolInput had ERRORS
---> test runtestRecoEgammaPhotonIdentification had ERRORS
---> test runtestRecoEgammaElectronIdentification had ERRORS
---> test runtestTqafExamples had ERRORS
---> test runtestTqafTopEventProducers had ERRORS
---> test runtestPhysicsToolsNanoAOD had ERRORS
---> test runtestPhysicsToolsPatAlgos had ERRORS
---> test testTauEmbeddingProducers had ERRORS
---> test SiStripDAQ_O2O_test had ERRORS

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4674/32995/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 196 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3097440
  • DQMHistoTests: Total failures: 162
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3097081
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@mrodozov
Copy link
Contributor Author

mrodozov commented Feb 6, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4674/33022/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 194 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3097440
  • DQMHistoTests: Total failures: 15
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3097228
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/run-pr-tests/5/console Started: 2019/02/08 10:15
https://cmssdt.cern.ch/jenkins/job/run-pr-tests/6/console Started: 2019/02/08 10:17

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2019

-1

Tested at: be42eac

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e288c/6/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test testConditionDatabase_2 had ERRORS
---> test TestPoolInput had ERRORS
---> test materialBudgetTrackerPlots had ERRORS
---> test testSSTGainPCL_fromRECO had ERRORS
---> test runtestRecoEgammaPhotonIdentification had ERRORS
---> test runtestRecoEgammaElectronIdentification had ERRORS
---> test testRecoMETMETProducers had ERRORS
---> test runtestTqafTopEventProducers had ERRORS
---> test runtestTqafExamples had ERRORS
---> test runtestPhysicsToolsPatAlgos had ERRORS
---> test testTauEmbeddingProducers had ERRORS
---> test testPhase2PixelNtuple had ERRORS
---> test runtestPhysicsToolsNanoAOD had ERRORS
---> test SiStripDAQ_O2O_test had ERRORS

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2019

Comparison job queued.

@smuzaffar smuzaffar merged commit e6b173d into cms-sw:IB/CMSSW_10_5_X/rootmaster Feb 9, 2019
@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e288c/6/summary.html

The workflows 1001.0, 1000.0, 140.53, 136.85, 136.8311, 136.7611, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 194 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3097440
  • DQMHistoTests: Total failures: 15
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3097228
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants