Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated root to tip of branch master #8777

Conversation

iarspider
Copy link
Contributor

No description provided.

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for branch IB/CMSSW_13_3_X/rootmaster.

@iarspider, @aandvalenzuela, @smuzaffar can you please review it and eventually sign? Thanks.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-61ec6e/35343/summary.html
COMMIT: 50902aa
CMSSW: CMSSW_13_3_ROOT6_X_2023-10-22-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8777/35343/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Package CalibTracker/SiPixelGainCalibration built
Entering library rule at src/CalibTracker/SiPixelGainCalibration/plugins
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_ROOT6_X_2023-10-22-2300/src/CalibTracker/SiPixelGainCalibration/plugins/SiPixelCalibDigiProducer.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_ROOT6_X_2023-10-22-2300/src/CalibTracker/SiPixelGainCalibration/plugins/SiPixelGainCalibrationAnalysis.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_ROOT6_X_2023-10-22-2300/src/CalibTracker/SiPixelGainCalibration/plugins/SiPixelGainCalibrationAnalysis.cc: In member function 'virtual bool SiPixelGainCalibrationAnalysis::doFits(uint32_t, std::vector::const_iterator)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_ROOT6_X_2023-10-22-2300/src/CalibTracker/SiPixelGainCalibration/plugins/SiPixelGainCalibrationAnalysis.cc:347:11: error: 'isnan' was not declared in this scope; did you mean 'std::isnan'?
  347 |   while ((isnan(slope) || isnan(intercept)) && ntimes < 10) {
      |           ^~~~~
      |           std::isnan
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/lcg/root/6.31.01-c9ced9c4434e96a063e6514dc37a776f/include/TMathBase.h:32,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/lcg/root/6.31.01-c9ced9c4434e96a063e6514dc37a776f/include/TString.h:28,


@iarspider
Copy link
Contributor Author

please test with cms-sw/cmssw#43086

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-61ec6e/35354/summary.html
COMMIT: 50902aa
CMSSW: CMSSW_13_3_X_2023-10-23-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8777/35354/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-61ec6e/35354/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-61ec6e/35354/git-merge-result

Build

I found compilation error when building:

#10 0x0000000000406fce in _start ()
===========================================================


/bin/sh: line 1: 1224624 Segmentation fault      (core dumped) edmWriteConfigs -p /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_X_2023-10-23-1100/tmp/el8_amd64_gcc12/src/Calibration/LumiAlCaRecoProducers/plugins/AlcaPCCEventProducer/libAlcaPCCEventProducer.so
gmake: *** [lib/el8_amd64_gcc12/AlcaPCCEventProducer.edmplugin] Error 1
Entering library rule at src/Calibration/LumiAlCaRecoProducers/plugins
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_X_2023-10-23-1100/src/Calibration/LumiAlCaRecoProducers/plugins/AlcaPCCIntegrator.cc
>> Building edm plugin tmp/el8_amd64_gcc12/src/Calibration/LumiAlCaRecoProducers/plugins/AlcaPCCIntegrator/libAlcaPCCIntegrator.so
Leaving library rule at src/Calibration/LumiAlCaRecoProducers/plugins
@@@@ Running edmWriteConfigs for AlcaPCCIntegrator


Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

>> Entering Package Utilities/LStoreAdaptor
>> Entering Package Utilities/PPS
>> Entering Package Utilities/StorageFactory
>> Entering Package Utilities/XrdAdaptor
>> Compile sequence completed for CMSSW CMSSW_13_3_X_2023-10-23-1100
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1
+ eval scram build outputlog '&&' '(python3' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cms-bot/buildLogAnalyzer.py --logDir /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_X_2023-10-23-1100/tmp/el8_amd64_gcc12/cache/log/src '||' 'true)'
++ scram build outputlog
>> Entering Package CalibPPS/ESProducers
Entering library rule at src/CalibPPS/ESProducers/plugins
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_X_2023-10-23-1100/src/CalibPPS/ESProducers/plugins/CTPPSAlignmentInfo.cc


@iarspider
Copy link
Contributor Author

please test with cms-sw/cmssw#43086 for CMSSW_13_3_ROOT6_X

@smuzaffar
Copy link
Contributor

@smuzaffar
Copy link
Contributor

please test for CMSSW_13_3_ROOT6_X

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-61ec6e/35383/summary.html
COMMIT: 50902aa
CMSSW: CMSSW_13_3_ROOT6_X_2023-10-23-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8777/35383/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_ROOT6_X_2023-10-23-2300/src/RecoEgamma/PhotonIdentification/src/PhotonDNNEstimator.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_ROOT6_X_2023-10-23-2300/src/RecoEgamma/PhotonIdentification/src/PhotonIsolationCalculator.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_ROOT6_X_2023-10-23-2300/src/RecoEgamma/PhotonIdentification/src/PhotonMIPHaloTagger.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_ROOT6_X_2023-10-23-2300/src/RecoEgamma/PhotonIdentification/src/PhotonMVABasedHaloTagger.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_ROOT6_X_2023-10-23-2300/src/RecoEgamma/PhotonIdentification/src/PhotonMVABasedHaloTagger.cc: In member function 'double PhotonMVABasedHaloTagger::calculateMVA(const reco::Photon*, const GBRForest*, const edm::Event&, const edm::EventSetup&)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_ROOT6_X_2023-10-23-2300/src/RecoEgamma/PhotonIdentification/src/PhotonMVABasedHaloTagger.cc:92:17: error: 'isnan' was not declared in this scope; did you mean 'std::isnan'?
   92 |   double spp = (isnan(vCov[2]) ? 0. : sqrt(vCov[2]));
      |                 ^~~~~
      |                 std::isnan
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/lcg/root/6.31.01-c9ced9c4434e96a063e6514dc37a776f/include/TMathBase.h:32,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/lcg/root/6.31.01-c9ced9c4434e96a063e6514dc37a776f/include/TString.h:28,


@iarspider
Copy link
Contributor Author

iarspider commented Oct 24, 2023

@iarspider
Copy link
Contributor Author

please test for CMSSW_13_3_ROOT6_X

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-61ec6e/35397/summary.html
COMMIT: 50902aa
CMSSW: CMSSW_13_3_ROOT6_X_2023-10-23-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8777/35397/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-61ec6e/35397/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-61ec6e/35397/git-merge-result

Build

I found compilation error when building:

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_ROOT6_X_2023-10-23-2300/src/Validation/MtdValidation/plugins/MtdTracksHarvester.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_ROOT6_X_2023-10-23-2300/src/Validation/MtdValidation/plugins/MtdTracksValidation.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_ROOT6_X_2023-10-23-2300/src/Validation/MtdValidation/plugins/Primary4DVertexHarvester.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_ROOT6_X_2023-10-23-2300/src/Validation/MtdValidation/plugins/Primary4DVertexValidation.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_ROOT6_X_2023-10-23-2300/src/Validation/MtdValidation/plugins/Primary4DVertexValidation.cc: In member function 'virtual void Primary4DVertexValidation::analyze(const edm::Event&, const edm::EventSetup&)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_ROOT6_X_2023-10-23-2300/src/Validation/MtdValidation/plugins/Primary4DVertexValidation.cc:1326:26: error: 'isnan' was not declared in this scope; did you mean 'std::isnan'?
 1326 |               } else if (isnan(probPi[*iTrack])) {
      |                          ^~~~~
      |                          std::isnan
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/lcg/root/6.31.01-c9ced9c4434e96a063e6514dc37a776f/include/TMathBase.h:32,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/lcg/root/6.31.01-c9ced9c4434e96a063e6514dc37a776f/include/TString.h:28,


@iarspider
Copy link
Contributor Author

please test for CMSSW_13_3_ROOT6_X

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-61ec6e/35400/summary.html
COMMIT: 50902aa
CMSSW: CMSSW_13_3_ROOT6_X_2023-10-24-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8777/35400/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-61ec6e/35400/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-61ec6e/35400/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test testTauEmbeddingProducers had ERRORS

Comparison Summary

Summary:

  • You potentially added 61 lines to the logs
  • Reco comparison results: 3864 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3351458
  • DQMHistoTests: Total failures: 31875
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3319561
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 166 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 1 / 47 workflows

@iarspider
Copy link
Contributor Author

UT failure is unrelated, see cms-sw/cmssw#43116

@smuzaffar
Copy link
Contributor

we need to wait for cms-sw/cmssw#43104 to merge first

@smuzaffar
Copy link
Contributor

smuzaffar commented Oct 27, 2023

+externals
Required cmssw PRs are merged now, so lets get this in for next ROOT6 IB

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_3_X/rootmaster IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar merged commit 44329ee into cms-sw:IB/CMSSW_13_3_X/rootmaster Oct 27, 2023
10 of 12 checks passed
@iarspider iarspider deleted the root-update-master-20231023 branch February 12, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants