Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing namespace to isnan calls #43104

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Conversation

iarspider
Copy link
Contributor

PR description:

See description. Technical fix, required to update ROOTmaster

PR validation:

Bot tests here + cms-sw/cmsdist#8777

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43104/37348

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for master.

It involves the following packages:

  • RecoEgamma/PhotonIdentification (reconstruction)

@cmsbuild, @mandrenguyen, @jfernan2 can you please review it and eventually sign? Thanks.
@sobhatta, @valsdav, @Sam-Harper, @a-kapoor, @Prasant1993, @sameasy, @afiqaize, @varuns23, @jainshilpi, @missirol, @ram1123, @lgray this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43104/37350

  • This PR adds an extra 36KB to repository

@cmsbuild
Copy link
Contributor

Pull request #43104 was updated. @rvenditti, @syuvivida, @mandrenguyen, @nothingface0, @antoniovagnerini, @tjavaid, @cmsbuild, @jfernan2 can you please check and sign again.

@iarspider iarspider changed the title [WIP] Add missing namespace to isnan calls Add missing namespace to isnan calls Oct 26, 2023
@iarspider
Copy link
Contributor Author

please test

@smuzaffar
Copy link
Contributor

@cms-sw/dqm-l2 @cms-sw/reconstruction-l2 can you please review this. It is just a technical fix ( adding missing std namespace for isnan)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e67a65/35426/summary.html
COMMIT: c34d549
CMSSW: CMSSW_13_3_X_2023-10-25-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43104/35426/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3357400
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3357375
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@tjavaid
Copy link

tjavaid commented Oct 26, 2023

+1

@jfernan2
Copy link
Contributor

+reconstruction

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar
Copy link
Contributor

@rappoccio @antoniovilela , can we merge this before 11h00 IB? This is needed for ROOT master IBs

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 0baa649 into cms-sw:master Oct 27, 2023
11 checks passed
@iarspider iarspider deleted the patch-12 branch October 30, 2023 12:38
@iarspider iarspider restored the patch-12 branch November 20, 2023 07:56
@iarspider iarspider deleted the patch-12 branch November 20, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants