Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROOT master] Integrate new PyROOT with CMSSW #5531

Merged

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented Feb 10, 2020

please test
no updates from https://sft.its.cern.ch/jira/browse/ROOT-10545 but lets get the new commits

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 10, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4567/console Started: 2020/02/10 12:43

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_11_1_X/rootmaster.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Tested at: 26c9a0d

CMSSW: CMSSW_11_1_ROOT6_X_2020-02-09-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7c334a/4567/summary.html

I found follow errors while testing this PR

Failed tests: Build

  • Build:

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_ROOT6_X_2020-02-09-2300/src/DetectorDescription/DDCMS/plugins/dd4hep/DDTestVectorAlgo.cc 
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_ROOT6_X_2020-02-09-2300/src/DetectorDescription/DDCMS/plugins/dd4hep/DDAngular.cc 
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_ROOT6_X_2020-02-09-2300/src/DetectorDescription/DDCMS/plugins/dd4hep/DDDefinitions2Objects.cc 
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_ROOT6_X_2020-02-09-2300/src/DetectorDescription/DDCMS/plugins/dd4hep/DDLinear.cc 
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_ROOT6_X_2020-02-09-2300/src/DetectorDescription/DDCMS/plugins/dd4hep/DDAngular.cc: In function 'long int algorithm(dd4hep::Detector&, cms::DDParsingContext&, xml_h, dd4hep::SensitiveDetector&)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_ROOT6_X_2020-02-09-2300/src/DetectorDescription/DDCMS/plugins/dd4hep/DDAngular.cc:38:27: error: no match for 'operator+' (operand types are 'std::string_view' {aka 'std::basic_string_view'} and 'std::__cxx11::string' {aka 'std::__cxx11::basic_string'})
     childName = ns.name() + childName;
                 ~~~~~~~~~~^~~~~~~~~~~
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc820/lcg/root/6.19.01-7c334a/include/TNamed.h:26,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc820/lcg/root/6.19.01-7c334a/include/TGeoPhysicalNode.h:15,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc820/external/dd4hep/v01-10x-7c334a/include/DD4hep/Objects.h:46,


@cmsbuild
Copy link
Contributor

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

@cmsbuild
Copy link
Contributor

Pull request #5531 was updated.

@mrodozov
Copy link
Contributor Author

please test
this should build at least the externals

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 11, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4607/console Started: 2020/02/11 17:39

@cmsbuild
Copy link
Contributor

-1

Tested at: 297443f

CMSSW: CMSSW_11_1_ROOT6_X_2020-02-10-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7c334a/4607/summary.html

I found follow errors while testing this PR

Failed tests: Build

  • Build:

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_ROOT6_X_2020-02-10-2300/src/DetectorDescription/DDCMS/plugins/dd4hep/DDAngular.cc 
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_ROOT6_X_2020-02-10-2300/src/DetectorDescription/DDCMS/plugins/dd4hep/DDDefinitions2Objects.cc 
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_ROOT6_X_2020-02-10-2300/src/DetectorDescription/DDCMS/plugins/dd4hep/DDLinear.cc 
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_ROOT6_X_2020-02-10-2300/src/DetectorDescription/DDCMS/plugins/dd4hep/DDCMSDetElementCreator.cc 
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_ROOT6_X_2020-02-10-2300/src/DetectorDescription/DDCMS/plugins/dd4hep/DDAngular.cc: In function 'long int algorithm(dd4hep::Detector&, cms::DDParsingContext&, xml_h, dd4hep::SensitiveDetector&)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_ROOT6_X_2020-02-10-2300/src/DetectorDescription/DDCMS/plugins/dd4hep/DDAngular.cc:38:27: error: no match for 'operator+' (operand types are 'std::string_view' {aka 'std::basic_string_view'} and 'std::__cxx11::string' {aka 'std::__cxx11::basic_string'})
     childName = ns.name() + childName;
                 ~~~~~~~~~~^~~~~~~~~~~
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc820/lcg/root/6.19.01-7c334a/include/TNamed.h:26,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc820/lcg/root/6.19.01-7c334a/include/TGeoPhysicalNode.h:15,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc820/external/dd4hep/v01-10x-7c334a/include/DD4hep/Objects.h:46,


@cmsbuild
Copy link
Contributor

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 11, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

-1

Tested at: 6f863a5

CMSSW: CMSSW_11_1_ROOT6_X_2020-03-10-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7c334a/5132/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test import-rootpy had ERRORS
---> test testRootpy had ERRORS
---> test TestRunnerDataFormatsFWLite had ERRORS

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7c334a/5132/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2680577
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2680257
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@smuzaffar
Copy link
Contributor

+externals
lets get this in IBs to run all tests. rootpy unit tests failures are due to the fact that it does not support new pyroot.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_1_X/rootmaster IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants