Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROOT6] Updated root to tip of branch master #8247

Conversation

aandvalenzuela
Copy link
Contributor

No description provided.

@aandvalenzuela
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @aandvalenzuela (Andrea Valenzuela) for branch IB/CMSSW_13_0_X/rootmaster.

@smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@aandvalenzuela
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

Pull request #8247 was updated.

@smuzaffar
Copy link
Contributor

test parameters:

  • full_cmssw = true

@smuzaffar
Copy link
Contributor

please test

we need to do a full build as root version changed

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bdf6a4/29950/summary.html
COMMIT: f0bc1a3
CMSSW: CMSSW_13_0_ROOT6_X_2023-01-11-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8247/29950/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bdf6a4/29950/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bdf6a4/29950/git-merge-result

Build

I found compilation error when building:

--- Registered EDM Plugin: FWCoreIntegrationValueExample
Entering library rule at src/FWCore/Integration/plugins
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_ROOT6_X_2023-01-11-2300/src/FWCore/Integration/plugins/ValueExamplePlugin.cc
>> Building edm plugin tmp/el8_amd64_gcc11/src/FWCore/Integration/plugins/FWCoreIntegrationValueExamplePlugin/libFWCoreIntegrationValueExamplePlugin.so
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/gcc/11.2.1-f9b9dfdd886f71cd63f5538223d8f161/bin/../lib/gcc/x86_64-redhat-linux-gnu/11.2.1/../../../../x86_64-redhat-linux-gnu/bin/ld: cannot find -lFWCoreIntegrationValueExample
collect2: error: ld returned 1 exit status
gmake: *** [tmp/el8_amd64_gcc11/src/FWCore/Integration/plugins/FWCoreIntegrationValueExamplePlugin/libFWCoreIntegrationValueExamplePlugin.so] Error 1
Leaving library rule at src/FWCore/Integration/plugins
Entering library rule at src/FWCore/Integration/plugins
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_ROOT6_X_2023-01-11-2300/src/FWCore/Integration/plugins/AcquireIntProducer.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_ROOT6_X_2023-01-11-2300/src/FWCore/Integration/plugins/AcquireIntFilter.cc


@aandvalenzuela
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bdf6a4/29960/summary.html
COMMIT: f0bc1a3
CMSSW: CMSSW_13_0_ROOT6_X_2023-01-12-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8247/29960/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bdf6a4/29960/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bdf6a4/29960/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test TestIntegrationParameterSet had ERRORS
---> test TestIOPoolInputNoParentDictionary had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 13 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3555538
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3555507
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 211 log files, 162 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

+external

@smuzaffar smuzaffar merged commit ec40a93 into cms-sw:IB/CMSSW_13_0_X/rootmaster Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants