Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROOT master] Fixing commit is merged + few more #5914

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented Jun 7, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6861/console Started: 2020/06/07 14:51

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2020

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_11_2_X/rootmaster.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@mrodozov mrodozov changed the title [ROOT master] Fixing commits is merged + few more [ROOT master] Fixing commit is merged + few more Jun 7, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2020

+1
Tested at: 256cdd6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6154c9/6861/summary.html
CMSSW: CMSSW_11_2_ROOT6_X_2020-06-05-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6154c9/6861/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780497
  • DQMHistoTests: Total failures: 35
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780412
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@smuzaffar
Copy link
Contributor

+externals

@smuzaffar smuzaffar merged commit 2e5c5e8 into cms-sw:IB/CMSSW_11_2_X/rootmaster Jun 7, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2020

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_2_X/rootmaster IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

@mrodozov - great if these also go to the modules branch. I guess the forward ports don't handle this. I"ll update the modules branch to include this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants