Fix deprecated-copy warnings in CondFormats/OptAlignObjects

[iarspider]

PR description:

Implicit copy-constructors are deprecated, and not necessary in most cases. This PR removes unnnecessary copy-assignment operators (and swap methods) in favor of auto-generated ones.

PR validation:

Bot tests

[iarspider]

test parameters:

• full_cmssw = true

[iarspider]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43085/37319

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• CondFormats/OptAlignObjects (alca, db)

@saumyaphor4252, @francescobrivio, @perrotta, @consuegs can you please review it and eventually sign? Thanks.
@yuanchao, @mmusich, @PonIlya, @seemasharmafnal, @rsreds, @tocheng this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a32658/35352/summary.html
COMMIT: 14b98f7
CMSSW: CMSSW_13_3_X_2023-10-23-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43085/35352/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test TestGeneratorInterfacePythia8ConcurrentGeneratorFilter had ERRORS

Comparison Summary

Summary:

• You potentially removed 177 lines from the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3357400
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3357378
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[iarspider]

please test for CMSSW_13_3_DEVEL_X

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a32658/35363/summary.html
COMMIT: 14b98f7
CMSSW: CMSSW_13_3_DEVEL_X_2023-10-22-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43085/35363/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test TestGeneratorInterfacePythia8ConcurrentGeneratorFilter had ERRORS

Comparison Summary

Summary:

• You potentially removed 181 lines from the logs
• Reco comparison results: 22 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3357400
• DQMHistoTests: Total failures: 1067
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3356311
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[perrotta]

+1

• The removed copy constructor does not seem to be used anywhere in CMSSW
• The unit test error is already present in the IB: a fix is available in Correct url of the GEN fragment in a Pythia8Interface test and of the RelMon main page, after SSO migration #43093

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1

[rappoccio]

merge

• failures are unrelated.