Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated root to tip of branch master #8433

Conversation

iarspider
Copy link
Contributor

No description provided.

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for branch IB/CMSSW_13_1_X/rootmaster.

@smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46fb7a/31903/summary.html
COMMIT: 987061a
CMSSW: CMSSW_13_1_ROOT6_X_2023-04-10-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8433/31903/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_ROOT6_X_2023-04-10-2300/src/PhysicsTools/TagAndProbe/src/TPTreeFiller.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_ROOT6_X_2023-04-10-2300/src/PhysicsTools/TagAndProbe/src/TagProbeFitter.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_ROOT6_X_2023-04-10-2300/src/PhysicsTools/TagAndProbe/src/TagProbePairMaker.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_ROOT6_X_2023-04-10-2300/src/PhysicsTools/TagAndProbe/src/ZGeneratorLineShape.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_ROOT6_X_2023-04-10-2300/src/PhysicsTools/TagAndProbe/src/TagProbeFitter.cc: In member function 'void TagProbeFitter::saveFitPlot(RooWorkspace*)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_ROOT6_X_2023-04-10-2300/src/PhysicsTools/TagAndProbe/src/TagProbeFitter.cc:847:14: error: no matching function for call to 'RooAbsPdf::paramOn(RooPlot*&, RooAbsData*&, const char [1], int, const char [5], double, double, double)'
  847 |   pdf.paramOn(frames.back(), dataAll, "", 0, "NELU", 0.1, 0.9, 0.9);
      |   ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/lcg/root/6.29.01-51325eb3538b575459c1101d2de7223c/include/RooFit/TestStatistics/RooAbsL.h:18,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/lcg/root/6.29.01-51325eb3538b575459c1101d2de7223c/include/RooMinimizer.h:20,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_ROOT6_X_2023-04-10-2300/src/PhysicsTools/TagAndProbe/src/TagProbeFitter.cc:26:


@iarspider
Copy link
Contributor Author

iarspider commented Apr 11, 2023

The RooAbsPdf::paramOn overload used in CMSSW code was deprecated even in ROOT 6.06, and got removed in ROOT master: root-project/root#12608 .

@smuzaffar
Copy link
Contributor

@iarspider , please open an issue in cms-sw/cmssw

@smuzaffar
Copy link
Contributor

test parameters:

@smuzaffar
Copy link
Contributor

please test

@iarspider
Copy link
Contributor Author

@smuzaffar why did you disable "static" test?

@smuzaffar
Copy link
Contributor

@iarspider , static tests are enough to run via cmssw PR so in this case cms-sw/cmssw#41322 static tests will be good. Tests for cmssw+cmsdist PRs (specially for root PRs whcih checks out too many packages) can add extra 2/3 hours for PR tests :-)

@smuzaffar
Copy link
Contributor

please test for CMSSW_13_1_ROOT6_X

@iarspider
Copy link
Contributor Author

thanks for the explanation!

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46fb7a/31945/summary.html
COMMIT: 987061a
CMSSW: CMSSW_13_1_ROOT6_X_2023-04-11-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8433/31945/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test testDataFormatsScoutingRun3 had ERRORS
---> test testDataFormatsScoutingRun2 had ERRORS

Comparison Summary

Summary:

  • You potentially removed 4 lines from the logs
  • Reco comparison results: 17 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3459609
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3459581
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@smuzaffar smuzaffar merged commit a84dfab into cms-sw:IB/CMSSW_13_1_X/rootmaster Apr 13, 2023
@iarspider iarspider deleted the root-update-master-20230411 branch April 13, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants