Phase2L1CaloPFClusterEmulator: fix warnings in getEt

[iarspider]

PR description:

The followings warnings are emitted during compilation:

In function 'getEt',
    inlined from 'recoPfcluster' at /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/c0a3801c18577931e4a34d824c3c3171/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_13_3_DBG_X_2023-10-19-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloPFClusterEmulator.h:162:31,
    inlined from 'pfcluster' at /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/c0a3801c18577931e4a34d824c3c3171/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_13_3_DBG_X_2023-10-19-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloPFClusterEmulator.h:181:35,
    inlined from 'produce' at /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/c0a3801c18577931e4a34d824c3c3171/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_13_3_DBG_X_2023-10-19-2300/src/L1Trigger/L1CaloTrigger/plugins/Phase2L1CaloPFClusterEmulator.cc:149:38:
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/c0a3801c18577931e4a34d824c3c3171/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_13_3_DBG_X_2023-10-19-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloPFClusterEmulator.h:134:11: warning: 'et_sumEta[2]' may be used uninitialized [-Wmaybe-uninitialized]
   134 |     float pfcluster_et = et_sumEta[0] + et_sumEta[1] + et_sumEta[2];
      |           ^
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/c0a3801c18577931e4a34d824c3c3171/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_13_3_DBG_X_2023-10-19-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloPFClusterEmulator.h: In member function 'produce':
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/c0a3801c18577931e4a34d824c3c3171/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_13_3_DBG_X_2023-10-19-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloPFClusterEmulator.h:122:11: note: 'et_sumEta[2]' was declared here
  122 |     float et_sumEta[3];
      |           ^
In function 'getEt',
    inlined from 'recoPfcluster' at /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/c0a3801c18577931e4a34d824c3c3171/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_13_3_DBG_X_2023-10-19-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloPFClusterEmulator.h:162:31,
    inlined from 'pfcluster' at /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/c0a3801c18577931e4a34d824c3c3171/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_13_3_DBG_X_2023-10-19-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloPFClusterEmulator.h:181:35,
    inlined from 'produce' at /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/c0a3801c18577931e4a34d824c3c3171/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_13_3_DBG_X_2023-10-19-2300/src/L1Trigger/L1CaloTrigger/plugins/Phase2L1CaloPFClusterEmulator.cc:149:38:
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/c0a3801c18577931e4a34d824c3c3171/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_13_3_DBG_X_2023-10-19-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloPFClusterEmulator.h:134:39: warning: 'et_sumEta[1]' may be used uninitialized [-Wmaybe-uninitialized]
   134 |     float pfcluster_et = et_sumEta[0] + et_sumEta[1] + et_sumEta[2];
      |                                       ^
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/c0a3801c18577931e4a34d824c3c3171/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_13_3_DBG_X_2023-10-19-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloPFClusterEmulator.h: In member function 'produce':
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/c0a3801c18577931e4a34d824c3c3171/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_13_3_DBG_X_2023-10-19-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloPFClusterEmulator.h:122:11: note: 'et_sumEta[1]' was declared here
  122 |     float et_sumEta[3];
      |           ^
In function 'getEt',
    inlined from 'recoPfcluster' at /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/c0a3801c18577931e4a34d824c3c3171/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_13_3_DBG_X_2023-10-19-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloPFClusterEmulator.h:162:31,
    inlined from 'pfcluster' at /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/c0a3801c18577931e4a34d824c3c3171/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_13_3_DBG_X_2023-10-19-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloPFClusterEmulator.h:181:35,
    inlined from 'produce' at /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/c0a3801c18577931e4a34d824c3c3171/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_13_3_DBG_X_2023-10-19-2300/src/L1Trigger/L1CaloTrigger/plugins/Phase2L1CaloPFClusterEmulator.cc:149:38:
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/c0a3801c18577931e4a34d824c3c3171/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_13_3_DBG_X_2023-10-19-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloPFClusterEmulator.h:134:39: warning: 'et_sumEta[0]' may be used uninitialized [-Wmaybe-uninitialized]
   134 |     float pfcluster_et = et_sumEta[0] + et_sumEta[1] + et_sumEta[2];
      |                                       ^
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/c0a3801c18577931e4a34d824c3c3171/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_13_3_DBG_X_2023-10-19-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloPFClusterEmulator.h: In member function 'produce':
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/c0a3801c18577931e4a34d824c3c3171/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_13_3_DBG_X_2023-10-19-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloPFClusterEmulator.h:122:11: note: 'et_sumEta[0]' was declared here
  122 |     float et_sumEta[3];
      |           ^

PR validation:

Bot tests

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43070/37291

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• L1Trigger/L1CaloTrigger (upgrade, l1)

@srimanob, @AdrianoDee, @epalencia, @cmsbuild, @aloeliger can you please review it and eventually sign? Thanks.
@missirol, @Martin-Grunewald this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[iarspider]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-adb63e/35313/summary.html
COMMIT: db5d744
CMSSW: CMSSW_13_3_X_2023-10-19-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43070/35313/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 20 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3357400
• DQMHistoTests: Total failures: 1064
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3356314
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[aloeliger]

+l1

[srimanob]

+Upgrade

Technical PR to handle uninitialized variables.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1