Add maximum of pileup pT hats in JME custom NanoAOD

[nurfikri89]

PR description:

This PR adds the maximum of the pileup pT hats into the JME custom NanoAOD. This is done by modifying NPUTablesProducer.cc to find the maximum value in the vector<float> returned by getPU_pT_hats() and then store in the PileUp table.

A flag is also added and set to false in globals_cff.py so that this variable will not be stored in the main NanoAODs. The flag is set to true in custom_jme_cff.py so that it will be stored in the JME custom NanoAOD format.

The variable is needed by JERC analyses, which will use the JME Custom NanoAODs.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR needs to be backported to 10_6_X, once merged, for the ultra legacy campaigns.

[cmsbuild]

The code-checks are being triggered in jenkins.

[nurfikri89]

FYI JMAR convenors (@camclean @alefisico) and JERC contact (@anmalara)

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31831/19149

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/NanoAOD/python/custom_jme_cff.py modified in PR(s): Adding ability to output PF Candidate information in JME NTuples #31795, Add ParticleNetAK4 to JME custom NanoAOD #31714

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31831/19149/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31831/19149/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[mariadalfonso]

please test workflow 25202.15,10224.15,11024.15,1325.6,1325.7,1325.8,136.7952,1329.1,136.8521

[mariadalfonso]

@nurfikri89
please quote the size increase associated to the addition of vector of floats.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31831/19164

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/NanoAOD/python/custom_jme_cff.py modified in PR(s): Adding ability to output PF Candidate information in JME NTuples #31795, Add ParticleNetAK4 to JME custom NanoAOD #31714

[cmsbuild]

A new Pull Request was created by @nurfikri89 (Nurfikri Norjoharuddeen) for master.

It involves the following packages:

PhysicsTools/NanoAOD

@cmsbuild, @santocch, @mariadalfonso, @gouskos, @fgolf can you please review it and eventually sign? Thanks.
@gpetruc, @peruzzim, @swertz this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[nurfikri89]

@nurfikri89
please quote the size increase associated to the addition of vector of floats.

Hi @mariadalfonso, this only stores a single float and that it is not stored by default (by setting the flag to false) so that central nano are not touched, only just the JMEnano.

[mariadalfonso]

@nurfikri89
please quote the size increase associated to the addition of vector of floats.

Hi @mariadalfonso, this only stores a single float and that it is not stored by default (by setting the flag to false) so that central nano are not touched, only just the JMEnano.

yes, indeed, we need to know the JMEnano size increase/decrease for any update.
Please pick the ttbar MC with PU.
the JMEnano is becoming by far too large ~ > 10kB per event.

[nurfikri89]

@nurfikri89
please quote the size increase associated to the addition of vector of floats.

Hi @mariadalfonso, this only stores a single float and that it is not stored by default (by setting the flag to false) so that central nano are not touched, only just the JMEnano.

yes, indeed, we need to know the JMEnano size increase/decrease for any update.
Please pick the ttbar MC with PU.
the JMEnano is becoming by far too large ~ > 10kB per event.

Understood. Will make the test.

[nurfikri89]

@nurfikri89
please quote the size increase associated to the addition of vector of floats.

Hi @mariadalfonso, this only stores a single float and that it is not stored by default (by setting the flag to false) so that central nano are not touched, only just the JMEnano.

yes, indeed, we need to know the JMEnano size increase/decrease for any update.
Please pick the ttbar MC with PU.
the JMEnano is becoming by far too large ~ > 10kB per event.

Hi @mariadalfonso, by running over 5K events on a UL17 TTJets sample, the size per event is 9.478 kb/event which is an increase of 0.04% from 9.474 kb/event.

[mariadalfonso]

please test workflow 25202.15,10224.15,11024.15,1325.6,1325.7,1325.8,136.7952,1329.1,136.8521

[cmsbuild]

+1
Tested at: 1865a0a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2c96b2/10053/summary.html
CMSSW: CMSSW_11_2_X_2020-10-17-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2c96b2/10053/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-2c96b2/10224.15_TTbar_13+2017PU_JMENano+TTbar_13TeV_TuneCUETP8M1_GenSim+DigiPU+RecoFakeHLTPU+HARVESTFakeHLTPU+Nano
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-2c96b2/11024.15_TTbar_13+2018PU_JMENano+TTbar_13TeV_TuneCUETP8M1_GenSim+DigiPU+RecoFakeHLTPU+HARVESTFakeHLTPU+Nano
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-2c96b2/25202.15_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15MC_PU25_JME

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2543752
• DQMHistoTests: Total failures: 4
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2543726
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[mariadalfonso]

+xpog
minor addition to the JMEnano,

[silviodonato]

merge

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.