Backport of #31831 (Add maximum of pileup pT hats in JME custom NanoAOD) to 10_6_X

[nurfikri89]

Backport from #31831

PR description:

This PR adds the maximum of the pileup pT hats into the JME custom NanoAOD. This is done by modifying NPUTablesProducer.cc to find the maximum value in the vector<float> returned by getPU_pT_hats() and then store in the PileUp table.

A flag is also added and set to false in globals_cff.py so that this variable will not be stored in the main NanoAODs. The flag is set to true in custom_jme_cff.py so that it will be stored in the JME custom NanoAOD format.

The variable is needed by JERC analyses, which will use the JME Custom NanoAODs.

As mentioned in a comment in #31831, by running over 5K events on a UL17 TTJets sample, the size per event is 9.478 kb/event which is an increase of 0.04% from 9.474 kb/event.

if this PR is a backport please specify the original PR:

Original PR is #31831

[cmsbuild]

A new Pull Request was created by @nurfikri89 (Nurfikri Norjoharuddeen) for CMSSW_10_6_X.

It involves the following packages:

PhysicsTools/NanoAOD

@cmsbuild, @santocch, @mariadalfonso, @gouskos, @fgolf can you please review it and eventually sign? Thanks.
@gpetruc, @peruzzim, @swertz this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mariadalfonso]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_10_6_X_2020-10-20-1100/slc7_amd64_gcc700: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10128/console Started: 2020/10/20 14:27

[cmsbuild]

+1
Tested at: ec64b1c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d8b887/10128/summary.html
CMSSW: CMSSW_10_6_X_2020-10-20-1100
SCRAM_ARCH: slc7_amd64_gcc700

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d8b887/10128/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 3214663
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3214327
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 140 log files, 14 edm output root files, 34 DQM output files

[mariadalfonso]

+xpog
the changes are inline with master

(I noted that code-format tests are not triggered for backports and now looks like that the alignment of lines is not proper)

[qliphy]

code-checks

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31872/19393

• This PR adds an extra 8KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/NanoAOD/python/custom_jme_cff.py modified in PR(s): [10_6_X] DDXv2 and BTV changes in Nano #31618, #31786 #31847, [10_6_X] Add ParticleNetAK4 to JME custom NanoAOD. #31717

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31872/19393/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31872/19393/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[qliphy]

@nurfikri89 Can you have a check with above code-checks output? thanks!

[cmsbuild]

Pull request #31872 was updated. @cmsbuild, @santocch, @mariadalfonso, @gouskos, @fgolf can you please check and sign again.

[nurfikri89]

Hi @qliphy . I have applied the code-format patch.

[qliphy]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_10_6_X_2020-10-26-2300/slc7_amd64_gcc700: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10302/console Started: 2020/10/27 02:41

[cmsbuild]

+1
Tested at: ac92ae4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d8b887/10302/summary.html
CMSSW: CMSSW_10_6_X_2020-10-26-2300
SCRAM_ARCH: slc7_amd64_gcc700

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d8b887/10302/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 3214664
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3214328
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 140 log files, 14 edm output root files, 34 DQM output files

[qliphy]

@cms-sw/xpog-l2 Would you please review and sign again?

[mariadalfonso]

+xpog
the changes are inline with master

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1