Bug fix in HiPuRhoProducer.cc

[FHead]

PR description:

One-line bug fix in the jetty tower exclusion part of the code. The bug uses ieta instead of N(ieta) to calculate the number of towers.

Bug report in HIN PAG meeting: https://indico.cern.ch/event/1092697/#12-bug-report-in-cs-jet

PR validation:

The fix is checked to produce desired jet subtraction outcome.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is the initial. Not a backport.

additional info

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36489/27362

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @FHead (Yi Chen) for master.

It involves the following packages:

• RecoHI/HiJetAlgos (reconstruction)

@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks.
@yslai, @jazzitup, @yenjie, @kurtejung, @mandrenguyen, @dgulhan, @yetkinyilmaz this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-52a865/21262/summary.html
COMMIT: 502bf13
CMSSW: CMSSW_12_3_X_2021-12-13-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36489/21262/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 260 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 3250704
• DQMHistoTests: Total failures: 702
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3249979
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 41 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[slava77]

@FHead
I was looking at the slides and see that re-miniAOD is mentioned. Can this issue actually be fixed by rerunning on miniAOD (using the packedPFTowers)?

[slava77]

perhaps a problem here can become a good reason to consider to refactor the common code here and in RecoHI/HiJetAlgos/src/MultipleAlgoIterator.cc to be reused

[slava77]

type bug-fix

[slava77]

+reconstruction

for #36489 502bf13

• code changes are in line with the PR description and also matches a somewhat similar function in MultipleAlgoIterator::calculateOrphanInput
• jenkins tests pass and comparisons with the baseline show differences in heavy ion workflows starting from akCs4PFJets and in downstream/dependent quantities

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

[mandrenguyen]

@FHead I was looking at the slides and see that re-miniAOD is mentioned. Can this issue actually be fixed by rerunning on miniAOD (using the packedPFTowers)?

Hi @slava77 Yes, we are currently reclustering the jets when processing miniAOD as a workaround. I templated PFTowers to use packedPFCandates in order to run different radius jets, but due to this bug we're forced to do it for the standard R value as well. We plan a miniAOD reprocessing in mid-2022 such that this CPU-hungry reclustering at analysis level will no longer be needed afterwards.