-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Process modifier for 2018 PbPb miniAOD reprocessing #37984
Process modifier for 2018 PbPb miniAOD reprocessing #37984
Conversation
A new Pull Request was created by @mandrenguyen (Matthew Nguyen) for CMSSW_11_2_X. It involves the following packages:
@perrotta, @jordan-martins, @bbilin, @clacaputo, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @slava77, @jpata, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-abff34/24793/summary.html Comparison SummarySummary:
|
Hi @mandrenguyen , thanks for preparing this PR. I would expand it also including #37907. |
@clacaputo Ok, will do |
Pull request #37984 was updated. @perrotta, @jordan-martins, @bbilin, @clacaputo, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @slava77, @jpata, @qliphy, @fabiocos, @davidlange6 can you please check and sign again. |
Pull request #37984 was updated. @perrotta, @jordan-martins, @bbilin, @clacaputo, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @slava77, @jpata, @qliphy, @fabiocos, @davidlange6 can you please check and sign again. |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-abff34/24908/summary.html Comparison SummarySummary:
|
@cmsbuild please test These relval crashes appear to have nothing to do with this PR, and I don't manage to reproduce them interactively. Looks like cvmfs was unavailable or something. |
@cmsbuild please test |
@mandrenguyen I restarted the tests, but yes, those crashes are unrelated from this PR: would they show up again, just ignore them |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-abff34/25546/summary.html Comparison SummarySummary:
|
+reconstruction
|
@cms-sw/upgrade-l2 @cms-sw/pdmv-l2 Do you have any comment on this? |
+pdmv |
+Upgrade Re-sign |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_11_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will be automatically merged. |
@mandrenguyen CMSSW_11_2_5_patch2 is now ready https://cms-talk.web.cern.ch/t/patched-production-release-cmssw-11-2-5-patch2-now-available/11940 |
PR description:
Introduces a process modifier for reprocessing 2018 PbPb miniAOD, as requested by @clacaputo
This PR includes the bugfixes requested in #37907 and #37913, which fix issues in the jet UE subtraction and photon isolation used in heavy ions.
PR validation:
This process modifier is active in workflows 140.5611 (data) and 158.01 (MC)
When activated, this modifier fixes two bugs, one in the jet underlying subtraction, and one in the storing of information needed to redo the photon isolation.
if this PR is a backport please specify the original PR and why you need to backport that PR:
This PR contains a backport of #36489 and #37262 and is intended for a partial reprocessing of the 2018 PbPb miniAOD, as discussed in #37841
@FHead @ttrk
Before submitting your pull requests, make sure you followed this checklist: