Associated PF for Egamma in 2018 PbPb miniAOD #37262

ttrk · 2022-03-17T16:30:06Z

Description

PF candidate association is necessary for a GED electron/photon to avoid double counting energy in PF isolation.

In AOD, the association is stored in particleBasedIsolation object. In miniAOD, association is accessible via associatedPackedPFCandidates() of a pat electron/photon (e.g. here), the AOD-2-miniAOD process transfers the association between objects.

Currently, the transfer does not work correctly for 2018 PbPb data, i.e. run2_miniAOD_pp_on_AA_103X process. This is understood as packedPFcandidates in this workflow is made from an intermediate, "cleaned" PF collection (introduced via PR) and while references in particleBasedIsolation are still the ones from original PF collection. The associatedPackedPFCandidates collection created in current workflow is not correct.

This PR fixes the problem by producing a map between original (old) and the cleaned (new) PF candidate references and updating the references in particleBasedIsolation from old to new ones.

Validation
Tests pass wf 140.5611 and give correct output.

@mandrenguyen

cmsbuild · 2022-03-17T16:37:44Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37262/28885

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/PatAlgos/python/slimming/slimming_cff.py modified in PR(s): Dynamic Reduction Network for photon energy regression in miniAOD using the SonicTriton service #37134, Adding JPTjets to MiniAOD #36335

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37262/28885/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37262/28885/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2022-03-17T16:55:41Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37262/28887

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/PatAlgos/python/slimming/slimming_cff.py modified in PR(s): Dynamic Reduction Network for photon energy regression in miniAOD using the SonicTriton service #37134, Adding JPTjets to MiniAOD #36335

cmsbuild · 2022-03-17T16:56:09Z

A new Pull Request was created by @ttrk (Kaya Tatar) for master.

It involves the following packages:

PhysicsTools/PatAlgos (reconstruction)
RecoEgamma/EgammaPhotonProducers (reconstruction)
RecoHI/HiJetAlgos (reconstruction)

@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks.
@emilbols, @gouskos, @yslai, @jainshilpi, @hatakeyamak, @rappoccio, @mbluj, @demuller, @varuns23, @seemasharmafnal, @mmarionncern, @ahinzmann, @lgray, @jdolen, @sobhatta, @azotz, @mandrenguyen, @yetkinyilmaz, @Sam-Harper, @kurtejung, @rovere, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @dgulhan, @AlexDeMoor, @valsdav, @jazzitup, @JyothsnaKomaragiri, @yenjie, @lecriste, @afiqaize, @gpetruc, @wrtabb, @mariadalfonso, @andrzejnovak, @ram1123 this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

clacaputo · 2022-03-21T13:41:12Z

@cmsbuild please test

cmsbuild · 2022-03-21T23:57:26Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f7117e/23252/summary.html
COMMIT: 68ac690
CMSSW: CMSSW_12_4_X_2022-03-21-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37262/23252/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-f7117e/39434.911_TTbar_14TeV+2026D88_DD4hep+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3695650
DQMHistoTests: Total failures: 51289
DQMHistoTests: Total nulls: 67
DQMHistoTests: Total successes: 3644272
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 48 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 204 log files, 45 edm output root files, 49 DQM output files
TriggerResults: no differences found

clacaputo · 2022-03-23T17:41:34Z

Hi @smuzaffar , it is not clear to me whether the time out error is related to the PR or to jenkins

smuzaffar · 2022-03-23T18:39:47Z

@clacaputo , timeout is not related to this PR. the Relval INPUT tests try to run all workflows step1 . Looks like due to network issue that test timedout of 4 hour ( https://cmssdt.cern.ch/jenkins/job/ib-run-pr-relvals/17127/ ). I would suggest to ignore this error

clacaputo · 2022-03-24T09:28:44Z

test parameters:

workflow = 140.5611

clacaputo · 2022-03-24T09:28:56Z

@cmsbuild please test

cmsbuild · 2022-04-16T12:47:07Z

Pull request #37262 was updated. @jpata, @cmsbuild, @clacaputo, @slava77 can you please check and sign again.

clacaputo · 2022-04-19T08:29:25Z

@cmsbuild please test

cmsbuild · 2022-04-19T12:40:06Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f7117e/23998/summary.html
COMMIT: a9fc49b
CMSSW: CMSSW_12_4_X_2022-04-18-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37262/23998/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3594584
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3594554
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 48 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 203 log files, 46 edm output root files, 49 DQM output files
TriggerResults: no differences found

clacaputo · 2022-04-20T10:07:11Z

+reconstruction

resign

cmsbuild · 2022-04-20T10:07:35Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2022-04-25T00:43:56Z

please test
to refresh

cmsbuild · 2022-04-25T04:39:29Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f7117e/24172/summary.html
COMMIT: a9fc49b
CMSSW: CMSSW_12_4_X_2022-04-24-0000/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37262/24172/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-f7117e/39434.75_TTbar_14TeV+2026D88_HLT75e33+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HLT75e33+HARVESTGlobal

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3700081
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3700057
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 208 log files, 46 edm output root files, 50 DQM output files
TriggerResults: no differences found

perrotta · 2022-04-25T09:31:56Z

+1

Fix GED electron/photon PF association in run2 heavy-ion miniAOD

be8d658

cmsbuild added this to the CMSSW_12_4_X milestone Mar 17, 2022

cmsbuild added code-checks-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Mar 17, 2022

ttrk mentioned this pull request Mar 17, 2022

Fix Egamma PF linking in 2018 PbPb mAOD #37261

Closed

cmsbuild added code-checks-rejected and removed code-checks-pending labels Mar 17, 2022

apply code format

68ac690

cmsbuild added code-checks-pending and removed code-checks-rejected labels Mar 17, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 17, 2022

cmsbuild mentioned this pull request Mar 17, 2022

Dynamic Reduction Network for photon energy regression in miniAOD using the SonicTriton service #37134

Merged

cmsbuild added tests-started and removed tests-pending labels Mar 21, 2022

cmsbuild added tests-rejected and removed tests-started labels Mar 21, 2022

cmsbuild removed the tests-rejected label Mar 24, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 16, 2022

cmsbuild added tests-started and removed tests-pending labels Apr 19, 2022

cmsbuild added tests-approved and removed tests-started labels Apr 19, 2022

cmsbuild added fully-signed reconstruction-approved and removed reconstruction-pending pending-signatures labels Apr 20, 2022

cmsbuild added tests-started and removed tests-approved labels Apr 25, 2022

cmsbuild added tests-approved and removed tests-started labels Apr 25, 2022

cmsbuild added orp-approved and removed orp-pending labels Apr 25, 2022

cmsbuild merged commit 186a756 into cms-sw:master Apr 25, 2022

This was referenced Apr 25, 2022

[CXXMODULE] Update to latest root master changes cms-sw/cmsdist#7819

Merged

Can now disable CondorStatusUpdator #37673

Merged

mandrenguyen mentioned this pull request May 6, 2022

Backports for bugfixes to 2018 PbPb reMiniAOD in 11_2_X #37841

Closed

ttrk mentioned this pull request May 11, 2022

[11_2_X] Associated PF for Egamma in 2018 PbPb miniAOD #37907

Closed

mandrenguyen mentioned this pull request May 22, 2022

Process modifier for 2018 PbPb miniAOD reprocessing #37984

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Associated PF for Egamma in 2018 PbPb miniAOD #37262

Associated PF for Egamma in 2018 PbPb miniAOD #37262

ttrk commented Mar 17, 2022 •

edited

Loading

cmsbuild commented Mar 17, 2022

cmsbuild commented Mar 17, 2022

cmsbuild commented Mar 17, 2022

clacaputo commented Mar 21, 2022

cmsbuild commented Mar 21, 2022

clacaputo commented Mar 23, 2022

smuzaffar commented Mar 23, 2022

clacaputo commented Mar 24, 2022

clacaputo commented Mar 24, 2022

cmsbuild commented Apr 16, 2022

clacaputo commented Apr 19, 2022

cmsbuild commented Apr 19, 2022

clacaputo commented Apr 20, 2022

cmsbuild commented Apr 20, 2022

qliphy commented Apr 25, 2022

cmsbuild commented Apr 25, 2022

perrotta commented Apr 25, 2022

Associated PF for Egamma in 2018 PbPb miniAOD #37262

Associated PF for Egamma in 2018 PbPb miniAOD #37262

Conversation

ttrk commented Mar 17, 2022 • edited Loading

cmsbuild commented Mar 17, 2022

cmsbuild commented Mar 17, 2022

cmsbuild commented Mar 17, 2022

clacaputo commented Mar 21, 2022

cmsbuild commented Mar 21, 2022

RelVals-INPUT

Comparison Summary

clacaputo commented Mar 23, 2022

smuzaffar commented Mar 23, 2022

clacaputo commented Mar 24, 2022

clacaputo commented Mar 24, 2022

cmsbuild commented Apr 16, 2022

clacaputo commented Apr 19, 2022

cmsbuild commented Apr 19, 2022

Comparison Summary

clacaputo commented Apr 20, 2022

cmsbuild commented Apr 20, 2022

qliphy commented Apr 25, 2022

cmsbuild commented Apr 25, 2022

Comparison Summary

perrotta commented Apr 25, 2022

ttrk commented Mar 17, 2022 •

edited

Loading