Fix Egamma PF linking in 2018 PbPb mAOD #37261
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make both ME1a and ME1b LCT (A/CLCT) sorted into ring 1.
…pre6 HLT menu migration to 12_3_0_pre6 template
…GTsForRun3 Update TSG tests and Relval Steps to use new run3_[hlt|data]_relval GTs
[12.3.X] Bugfix for Strips O2O
…Plots-12_3_X_backport Lumi-based status plots, backport to CMSSW_12_3_X
…_12_3_X [12_3_X] Modernize `DQM/BeamMonitor/plugins/TKStatus` plugin
…_12_3_X [12.3.X] Introduce alignment campaign-like unit test for `pede`
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37261/28884
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
|
Sorry. Apparently this PR was done from an outdated branch. |
|
Opened a new PR using an updated branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated PF candidates for a GED electron/photon are necessary to avoid double counting energy in PF isolation.
In AOD, the association is stored in
particleBasedIsolationobject. In miniAOD, association is accessible viaassociatedPackedPFCandidates()of a pat electron/photon (e.g. here), the AOD-2-miniAOD process transfers the association between objects.Currently, the transfer does not work correctly for 2018 PbPb data, i.e.
run2_miniAOD_pp_on_AA_103Xprocess. This is understood as packedPFcandidates in this workflow is made from an intermediate, "cleaned" PF collection (created via this) and while references inparticleBasedIsolationare still the ones from original PF collection. TheassociatedPackedPFCandidatescollection created in current code is not correct.This PR fixes the problem by producing a map between original (old) and the cleaned (new) PF candidate references and updating the references in particleBasedIsolation from old to new ones.
Tests pass wf 140.5611 and give correct output.
@mandrenguyen