Fix BeamSpotAnalyzer::fillDescriptions

[mmusich]

PR description:

As reported by @francescobrivio, PR #35236 introduced a wrong type for the parameter BSAnalyzerParameters (which should be a PSet and non a VPSet).
This is fixed in this PR, together with completing the rest of descriptions coming from the BeamFitter and PVFitter classes.
I profit of this PR to introduce a unit test to check the functionality of the analyzer.

PR validation:

Relies on the unit tests provided in this PR

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

[mmusich]

type bug-fix

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37085/28570

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• RecoVertex/BeamSpotProducer (reconstruction, alca)

@malbouis, @yuanchao, @clacaputo, @cmsbuild, @slava77, @jpata, @tvami, @francescobrivio can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @tocheng, @mmusich, @mtosi, @dgulhan, @francescobrivio this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[francescobrivio]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2418d1/22710/summary.html
COMMIT: 83ae0ba
CMSSW: CMSSW_12_3_X_2022-02-27-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37085/22710/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 4001207
• DQMHistoTests: Total failures: 14
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4001171
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[tvami]

Sorry, I'm not sure what we expect to see in the unit test
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2418d1/22710/unitTests/src/RecoVertex/BeamSpotProducer/test/testBeamSpotAnalyzer/testing.log

 Total number of events processed: 0
-------------------------------------
%MSG-w BeamFitter: 
No event read! No Fitting!
%MSG
[BeamSpotAnalyzer] beamfit fails !!!

is this expected?

[mmusich]

is this expected?

of course it is....

cmssw/RecoVertex/BeamSpotProducer/test/testBeamSpotAnalyzer.cc

Line 18 in 83ae0ba

tester.testRunWithNoLuminosityBlocks();

[tvami]

+alca

• unit test results as expected
• Jenkins diffs show MsgLogger only
• code change in line w description

[jpata]

+reconstruction

• technical

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1