Add saturated EGM regression tags to Run-3 MC GTs #37102

tvami · 2022-03-01T18:07:56Z

PR description:

Add saturated electron and photon regression tags as requested in https://cms-talk.web.cern.ch/t/mc-update-of-new-egm-regression-conditions/4637/8

123X_mcRun3_2021_design_v10
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/123X_mcRun3_2021_design_v9/123X_mcRun3_2021_design_v10
123X_mcRun3_2021_realistic_v10
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/123X_mcRun3_2021_realistic_v9/123X_mcRun3_2021_realistic_v10
123X_mcRun3_2021cosmics_realistic_deco_v10
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/123X_mcRun3_2021cosmics_realistic_deco_v9/123X_mcRun3_2021cosmics_realistic_deco_v10
123X_mcRun3_2021_realistic_HI_v10
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/123X_mcRun3_2021_realistic_HI_v9/123X_mcRun3_2021_realistic_HI_v10
123X_mcRun3_2023_realistic_v10
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/123X_mcRun3_2023_realistic_v9/123X_mcRun3_2023_realistic_v10
123X_mcRun3_2024_realistic_v10
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/123X_mcRun3_2024_realistic_v9/123X_mcRun3_2024_realistic_v10
123X_mcRun4_realistic_v7
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/123X_mcRun4_realistic_v6/123X_mcRun4_realistic_v7

Diffs are in the 8 requested tags alone, except for the Phase-2 GT where the new L1T menu was also added [as a leftover from https://github.com//pull/37089] (no differences expected or observed related to this change.)

PR validation:

test parameters:

workflows = 12034.0,11634.0,7.23,159.0,12434.0,12834.0

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

tvami · 2022-03-01T18:09:51Z

test parameters:

workflows = 12034.0,11634.0,7.23,159.0,12434.0,12834.0
pull_request = Adapt to new range for BDT output for Run3 Saturated regression #37100

tvami · 2022-03-01T18:10:52Z

@cmsbuild , please test

cmsbuild · 2022-03-01T18:15:12Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37102/28597

This PR adds an extra 12KB to repository

cmsbuild · 2022-03-01T18:15:36Z

A new Pull Request was created by @tvami (Tamas Vami) for master.

It involves the following packages:

Configuration/AlCa (alca)

@malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2022-03-01T22:26:46Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f47de/22745/summary.html
COMMIT: 4c65ec5
CMSSW: CMSSW_12_3_X_2022-03-01-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37102/22745/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@mmusich Fix BeamSpotAnalyzer::fillDescriptions #37085

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f47de/22745/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f47de/22745/git-merge-result

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1f47de/12034.0_TTbar_14TeV+2021Design+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1f47de/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21

Summary:

No significant changes to the logs found
Reco comparison results: 511 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 4000857
DQMHistoTests: Total failures: 84
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4000751
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 204 log files, 45 edm output root files, 49 DQM output files
TriggerResults: no differences found

francescobrivio · 2022-03-01T22:33:16Z

@swagata87 I tought the saturated EGM was affecting the high pT electrons, but in the test comparison I see the LowPtElectron has differences (here for example). Could you clarify if this is expected?

francescobrivio · 2022-03-01T22:36:20Z

@tvami could you update the PR description to include the fact that this PR complements #37089 by including the new L1T menu in auto:phase2_realistic?
For completeness: no differences expected or observed related to this change.

swagata87 · 2022-03-01T23:04:13Z

@swagata87 I tought the saturated EGM was affecting the high pT electrons, but in the test comparison I see the LowPtElectron has differences (here for example). Could you clarify if this is expected?

Hi @francescobrivio
thanks! good catch
apparently, lowPtRegressionModifier clones the regressionModifier106XUL

cmssw/RecoEgamma/EgammaElectronProducers/python/lowPtGsfElectrons_cfi.py

Line 5 in 92e9d9d

lowPtRegressionModifier = regressionModifier106XUL.clone(

and then makes necessary changes on top of it.

So in my PR(#37100) since I changed regressionModifier106XUL, it gets propagated to lowPtRegressionModifier.

I saw @perrotta suggested some changes in #37100, which will address this issue as well. I will implement his suggestions soon

francescobrivio · 2022-03-01T23:09:26Z

hold

needs some fixes in Adapt to new range for BDT output for Run3 Saturated regression #37100 as described in Add saturated EGM regression tags to Run-3 MC GTs #37102 (comment)

cmsbuild · 2022-03-01T23:09:43Z

Pull request has been put on hold by @francescobrivio
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

francescobrivio · 2022-03-02T16:22:05Z

unhold

francescobrivio · 2022-03-02T16:22:20Z

@cmsbuild please test

cmsbuild · 2022-03-02T20:31:17Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f47de/22776/summary.html
COMMIT: 4c65ec5
CMSSW: CMSSW_12_3_X_2022-03-02-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37102/22776/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1f47de/12034.0_TTbar_14TeV+2021Design+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1f47de/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21

Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3990927
DQMHistoTests: Total failures: 8
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3990897
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 204 log files, 45 edm output root files, 49 DQM output files
TriggerResults: no differences found

francescobrivio · 2022-03-03T12:05:51Z

+alca

tests are now clean
should be merged together with Adapt to new range for BDT output for Run3 Saturated regression #37100

cmsbuild · 2022-03-03T12:06:09Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

francescobrivio · 2022-03-03T12:06:27Z

urgent

we have other change for the MC GTs in the pipeline targeting pre6

perrotta · 2022-03-03T14:19:33Z

+1

Add saturated EGM regression tags to Run-3 MC GTs

4c65ec5

cmsbuild added this to the CMSSW_12_3_X milestone Mar 1, 2022

cmsbuild added alca-pending code-checks-pending orp-pending pending-signatures tests-pending labels Mar 1, 2022

tvami mentioned this pull request Mar 1, 2022

Adapt to new range for BDT output for Run3 Saturated regression #37100

Merged

cmsbuild added the requires-external label Mar 1, 2022

cmsbuild added tests-started and removed tests-pending labels Mar 1, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 1, 2022

cmsbuild added tests-approved and removed tests-started labels Mar 1, 2022

cmsbuild added the hold label Mar 1, 2022

cmsbuild removed hold tests-approved labels Mar 2, 2022

cmsbuild added the tests-started label Mar 2, 2022

cmsbuild added tests-approved and removed tests-started labels Mar 2, 2022

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Mar 3, 2022

cmsbuild added the urgent label Mar 3, 2022

cmsbuild added orp-approved and removed orp-pending labels Mar 3, 2022

cmsbuild merged commit 099753a into cms-sw:master Mar 3, 2022

cmsbuild mentioned this pull request Mar 3, 2022

Add AlcaPCCIntegrator modules to the AlCa no ConcurrentLumis list #37130

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add saturated EGM regression tags to Run-3 MC GTs #37102

Add saturated EGM regression tags to Run-3 MC GTs #37102

tvami commented Mar 1, 2022 •

edited

Loading

tvami commented Mar 1, 2022

tvami commented Mar 1, 2022

cmsbuild commented Mar 1, 2022

cmsbuild commented Mar 1, 2022

cmsbuild commented Mar 1, 2022

francescobrivio commented Mar 1, 2022 •

edited

Loading

francescobrivio commented Mar 1, 2022

swagata87 commented Mar 1, 2022

francescobrivio commented Mar 1, 2022

cmsbuild commented Mar 1, 2022

francescobrivio commented Mar 2, 2022

francescobrivio commented Mar 2, 2022

cmsbuild commented Mar 2, 2022

francescobrivio commented Mar 3, 2022

cmsbuild commented Mar 3, 2022

francescobrivio commented Mar 3, 2022

perrotta commented Mar 3, 2022

Add saturated EGM regression tags to Run-3 MC GTs #37102

Add saturated EGM regression tags to Run-3 MC GTs #37102

Conversation

tvami commented Mar 1, 2022 • edited Loading

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

tvami commented Mar 1, 2022

tvami commented Mar 1, 2022

cmsbuild commented Mar 1, 2022

cmsbuild commented Mar 1, 2022

cmsbuild commented Mar 1, 2022

Comparison Summary

francescobrivio commented Mar 1, 2022 • edited Loading

francescobrivio commented Mar 1, 2022

swagata87 commented Mar 1, 2022

francescobrivio commented Mar 1, 2022

cmsbuild commented Mar 1, 2022

francescobrivio commented Mar 2, 2022

francescobrivio commented Mar 2, 2022

cmsbuild commented Mar 2, 2022

Comparison Summary

francescobrivio commented Mar 3, 2022

cmsbuild commented Mar 3, 2022

francescobrivio commented Mar 3, 2022

perrotta commented Mar 3, 2022

tvami commented Mar 1, 2022 •

edited

Loading

francescobrivio commented Mar 1, 2022 •

edited

Loading