Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AlcaPCCIntegrator modules to the AlCa no ConcurrentLumis list #37130

Merged
merged 1 commit into from
Mar 5, 2022

Conversation

tvami
Copy link
Contributor

@tvami tvami commented Mar 3, 2022

PR description:

A possible fix for
https://cmssdt.cern.ch/SDT/cgi-bin/logreader/slc7_amd64_gcc10/CMSSW_12_3_X_2022-03-02-2300/pyRelValMatrixLogs/run/1020.0_AlCaLumiPixels2021+AlCaLumiPixels2021+TIER0EXPLP+ALCAEXPLP+ALCAHARVLP+TIER0PROMPTLP/step2_AlCaLumiPixels2021+AlCaLumiPixels2021+TIER0EXPLP+ALCAEXPLP+ALCAHARVLP+TIER0PROMPTLP.log#/

PR validation:

None, will test it in Jenkins with multi-threaded options

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

@tvami
Copy link
Contributor Author

tvami commented Mar 3, 2022

test parameters:

  • enable_test = threading
  • workflow_threading = 1020.0
  • workflows = 1020.0

@tvami
Copy link
Contributor Author

tvami commented Mar 3, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37130/28661

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2022

A new Pull Request was created by @tvami (Tamas Vami) for master.

It involves the following packages:

  • Configuration/AlCa (alca)

@malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2022

-1

Failed Tests: RelVals-THREADING
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f7ba25/22805/summary.html
COMMIT: 8cbde66
CMSSW: CMSSW_12_3_X_2022-03-03-1100/slc7_amd64_gcc10
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37130/22805/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f7ba25/22805/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f7ba25/22805/git-merge-result

RelVals-THREADING

  • 1020.01020.0_AlCaLumiPixels2021+AlCaLumiPixels2021+TIER0EXPLP+ALCAEXPLP+ALCAHARVLP+TIER0PROMPTLP/step2_AlCaLumiPixels2021+AlCaLumiPixels2021+TIER0EXPLP+ALCAEXPLP+ALCAHARVLP+TIER0PROMPTLP.log

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-f7ba25/1020.0_AlCaLumiPixels2021+AlCaLumiPixels2021+TIER0EXPLP+ALCAEXPLP+ALCAHARVLP+TIER0PROMPTLP

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3987741
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3987711
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor Author

tvami commented Mar 3, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37130/28669

  • This PR adds an extra 52KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@tvami
Copy link
Contributor Author

tvami commented Mar 4, 2022

Thanks @mmusich for the fix! I've pushed it. I propose that we merge this quick fix, so that pre6 doesnt have an issue, and then we ask the Lumi team to develop the thread-safe version of AlcaPCCIntegrator.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37130/28691

  • This PR adds an extra 12KB to repository

@tvami
Copy link
Contributor Author

tvami commented Mar 4, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2022

Pull request #37130 was updated. @malbouis, @tvami, @yuanchao, @francescobrivio can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f7ba25/22861/summary.html
COMMIT: a9ee76f
CMSSW: CMSSW_12_3_X_2022-03-04-1100/slc7_amd64_gcc10
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37130/22861/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-f7ba25/1020.0_AlCaLumiPixels2021+AlCaLumiPixels2021+TIER0EXPLP+ALCAEXPLP+ALCAHARVLP+TIER0PROMPTLP

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3987741
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3987705
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor Author

tvami commented Mar 5, 2022

type bug-fix

@malbouis
Copy link
Contributor

malbouis commented Mar 5, 2022

+alca

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Mar 5, 2022

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants