[HGCAL trigger] Technical developments on Stage 1 emulator, validation and floating point compression

[jbsauvan]

PR description

Technical developments:

• Stage 1 emulator developments for and following comparison tests with firmware
  • To be noted that the Stage 1 emulator is not run in standard sequences
• Fixes and updates in the validation code
• Floating point compression code now working in 64bits

Associated internal PRs and reviews:

• Analyzer for extraction of trigger geometry and backend S1 parameters into a JSON file hgc-tpg/cmssw#11
• get the geometry with HGCalTriggeTools using setGeometry() method hgc-tpg/cmssw#6
• Saving reduced module hash matching firmware definition hgc-tpg/cmssw#17
• FP compression now working in 64-bit hgc-tpg/cmssw#19
• FPGA ID / output file as optional arguments hgc-tpg/cmssw#38
• Apply code-format hgc-tpg/cmssw#40
• Fix ID in validation hgc-tpg/cmssw#41
• HGCalTriggerGeometryBase: stage1_to_lpgbts_ now a map of vectors of lpgbtIDs hgc-tpg/cmssw#42

PR validation

Tested D86, D92, D9 workflows

runTheMatrix.py -w upgrade -l 20034.0 --maxSteps=2 & # D86
runTheMatrix.py -w upgrade -l 22434.0 --maxSteps=2 & # D92
runTheMatrix.py -w upgrade -l 23234.0 --maxSteps=2 & # D94

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42856/36994

• This PR adds an extra 64KB to repository

[cmsbuild]

A new Pull Request was created by @jbsauvan (Jean-Baptiste Sauvan) for master.

It involves the following packages:

• L1Trigger/L1THGCal (upgrade, l1)
• Validation/HGCalValidation (dqm)

@aloeliger, @epalencia, @nothingface0, @emanueleusai, @cmsbuild, @AdrianoDee, @srimanob, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@youyingli, @vandreev11, @sethzenz, @bsunanda, @rovere, @lgray, @Martin-Grunewald, @apsallid, @cseez, @pfs, @lecriste, @hatakeyamak, @missirol, @amarini, @ebrondol this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[jbsauvan]

Hello, would it be possible to trigger the tests?
Thanks a lot!

[srimanob]

@cmsbuild please test

[cmsbuild]

-1

Failed Tests: ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8ec00a/34994/summary.html
COMMIT: f26f1fd
CMSSW: CMSSW_13_3_X_2023-10-01-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42856/34994/install.sh to create a dev area with all the needed externals and cmssw changes.

Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

[aloeliger]

You likely don't mean tc_ueta = tc_ueta here. This is what is causing the build errors. What should this actually be?

[jbsauvan]

Thanks @aloeliger
It is actually doing what it should be. Just the way it is written that is not ideal.
I will rewrite that.

[srimanob]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8ec00a/35057/summary.html
COMMIT: 71e7867
CMSSW: CMSSW_13_3_X_2023-10-04-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42856/35057/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 4 lines from the logs
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3356920
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3356892
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[aloeliger]

+l1

[srimanob]

+Upgrade

[tjavaid]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1