Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary using namespace directive in WriteCTPPSTotemDAQMappingMask #42985

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

rsreds
Copy link
Contributor

@rsreds rsreds commented Oct 11, 2023

PR description:

This is a simple PR to remove using namespace directives and explicitly use the std:: declaration where needed in CondTools/CTPPS/plugins/WriteCTPPSTotemDAQMappingMask.cc

This is in response to #42879 (comment)

PR validation:

The PR has been tested by running the same test described in the previous PR #42879 (CondTools/CTPPS/test/test_XML_to_SQLite_mapping.sh)
as well as the basic test procedures.

Replaced use of string with std::string.
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42985/37160

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rsreds (Simone Rossi Tisbeni) for master.

It involves the following packages:

  • CondTools/CTPPS (db)

@saumyaphor4252, @perrotta, @consuegs, @francescobrivio, @cmsbuild can you please review it and eventually sign? Thanks.
@rsreds, @mmusich, @PonIlya, @yuanchao, @fabferro this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-550fac/35132/summary.html
COMMIT: 33715df
CMSSW: CMSSW_13_3_X_2023-10-10-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42985/35132/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test test_XMLToSQLiteMapping had ERRORS

Comparison Summary

Summary:

  • You potentially added 7 lines to the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3356920
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3356895
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@rsreds
Copy link
Contributor Author

rsreds commented Oct 12, 2023

test parameters:

  • addpkg = CalibPPS/ESProducers

@perrotta
Copy link
Contributor

test parameters:

  • addpkg = CalibPPS/ESProducers

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-550fac/35153/summary.html
COMMIT: 33715df
CMSSW: CMSSW_13_3_X_2023-10-11-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42985/35153/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 2500.52500.5_ScoutingNanodata13X/step2_ScoutingNanodata13X.log

Comparison Summary

Summary:

  • You potentially added 4 lines to the logs
  • Reco comparison results: 2509 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3356920
  • DQMHistoTests: Total failures: 3776
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3353122
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

+db

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@rappoccio
Copy link
Contributor

merge

  • Errors are unrelated.

@cmsbuild cmsbuild merged commit b59601d into cms-sw:master Oct 16, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants