-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary using namespace directive in WriteCTPPSTotemDAQMappingMask #42985
Conversation
Replaced use of string with std::string.
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42985/37160
|
A new Pull Request was created by @rsreds (Simone Rossi Tisbeni) for master. It involves the following packages:
@saumyaphor4252, @perrotta, @consuegs, @francescobrivio, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
-1 Failed Tests: UnitTests Unit TestsI found 1 errors in the following unit tests: ---> test test_XMLToSQLiteMapping had ERRORS Comparison SummarySummary:
|
test parameters:
|
test parameters:
|
please test |
-1 Failed Tests: RelVals-INPUT RelVals-INPUT
Comparison SummarySummary:
|
+db
|
This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
merge
|
PR description:
This is a simple PR to remove
using namespace
directives and explicitly use the std:: declaration where needed in CondTools/CTPPS/plugins/WriteCTPPSTotemDAQMappingMask.ccThis is in response to #42879 (comment)
PR validation:
The PR has been tested by running the same test described in the previous PR #42879 (CondTools/CTPPS/test/test_XML_to_SQLite_mapping.sh)
as well as the basic test procedures.