Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing import of TauolaPolar PSet in one Generator config #44499

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

perrotta
Copy link
Contributor

PR description:

Errors with workflow 13045 in one PR test revealed a missing import in the DYToTauTau_M-50_14TeV_pythia8_tauola_cff.py config
Apparently that workflow was not tested that often, otherwise it would have been noticed earlier on. Anyhow, the config is wrong and it should be fixed

PR validation:

Generator step of wf 13045 succeeds

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 21, 2024

cms-bot internal usage

@perrotta
Copy link
Contributor Author

test parameters:

  • workflows = 13045.0
  • relvals_opt = --what upgrade

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44499/39616

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @perrotta for master.

It involves the following packages:

  • Configuration/Generator (generators)

@bbilin, @menglu21, @SiewYan, @alberto-sanchez, @mkirsano, @cmsbuild, @GurpreetSinghChahal can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @fabiocos this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor Author

please test

@perrotta
Copy link
Contributor Author

perrotta commented Mar 21, 2024

type bug-fix

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4a4cec/38325/summary.html
COMMIT: 44ac825
CMSSW: CMSSW_14_1_X_2024-03-20-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44499/38325/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

@antoniovilela
Copy link
Contributor

+1

@antoniovilela
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 1a5ee3d into cms-sw:master Mar 26, 2024
12 checks passed
@perrotta perrotta deleted the addMissingReferenceForTauolaPolar branch March 26, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants