Phase2-hgx354D Fix the discrepancy in the translation of the flat file for new scintillator version of HGCal

[bsunanda]

PR description:

Fix the discrepancy in the translation of the flat file for new scintillator version of HGCal

PR validation:

This corrected version is used to make the XML files for the V19 version

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44521/39651

• This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44521/39651/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44521/39651/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44521/39652

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

• Geometry/HGCalCommonData (geometry, upgrade)

@mdhildreth, @Dr15Jones, @bsunanda, @civanch, @makortel, @srimanob, @cmsbuild, @subirsarkar can you please review it and eventually sign? Thanks.
@fabiocos this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please help

[bsunanda]

@cmsbuild Please test

[bsunanda]

+geometry

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e0b5ee/38358/summary.html
COMMIT: 352c20c
CMSSW: CMSSW_14_1_X_2024-03-22-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44521/38358/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 94 lines from the logs
• Reco comparison results: 52 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3297537
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3297508
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[bsunanda]

@srimanob Please approve this

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1