Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCC13] Temporary convert array-bounds errors into warnings #44646

Merged
merged 6 commits into from
Apr 18, 2024

Conversation

iarspider
Copy link
Contributor

@iarspider iarspider commented Apr 6, 2024

PR description:

In order to start testing gcc13 IBs, temporary convert array-bounds errors into warnings. See also #44582.

PR validation:

Bot tests

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2024

cms-bot internal usage

@iarspider
Copy link
Contributor Author

please test for el9_amd64_gcc13

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44646/39842

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2024

A new Pull Request was created by @iarspider for master.

It involves the following packages:

  • DQM/SiTrackerPhase2 (dqm)
  • DataFormats/TrackingRecHit (reconstruction)
  • SimG4CMS/HGCalTestBeam (simulation, upgrade)
  • TBDataFormats/HcalTBObjects (analysis)

@civanch, @rvenditti, @syuvivida, @tjavaid, @antoniovagnerini, @mandrenguyen, @srimanob, @tvami, @jfernan2, @nothingface0, @subirsarkar, @mdhildreth can you please review it and eventually sign? Thanks.
@gpetruc, @arossi83, @VourMa, @JanFSchulte, @missirol, @slomeo, @sroychow, @rovere, @mmusich, @bsunanda, @fabiocos, @VinInn, @mtosi this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2024

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0938c/38653/summary.html
COMMIT: f1e8229
CMSSW: CMSSW_14_1_X_2024-04-05-2300/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44646/38653/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02831/el9_amd64_gcc13/cms/cmssw/CMSSW_14_1_X_2024-04-05-2300/src/DataFormats/L1Trigger/interface/Muon.h:118:25: note:   by 'virtual bool l1t::Muon::operator!=(const l1t::Muon&) const'
  118 |     virtual inline bool operator!=(const l1t::Muon& rhs) const { return !(operator==(rhs)); };
      |                         ^~~~~~~~
>> Building edm plugin tmp/el9_amd64_gcc13/src/L1Trigger/L1TMuonBarrel/plugins/L1TriggerL1TMuonBarrelPlugins/libL1TriggerL1TMuonBarrelPlugins.so
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02831/el9_amd64_gcc13/external/gcc/13.2.0-1b0a3367d04f48f01ad3ccf40e55475c/bin/../lib/gcc/x86_64-redhat-linux-gnu/13.2.0/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: cannot find -lL1TriggerL1TMuonBarrel: No such file or directory
collect2: error: ld returned 1 exit status
gmake: *** [tmp/el9_amd64_gcc13/src/L1Trigger/L1TMuonBarrel/plugins/L1TriggerL1TMuonBarrelPlugins/libL1TriggerL1TMuonBarrelPlugins.so] Error 1
Leaving library rule at src/L1Trigger/L1TMuonBarrel/plugins
Entering library rule at L1Trigger/L1TMuonBarrel
>> Compiling  src/L1Trigger/L1TMuonBarrel/src/L1MuBMAssignmentUnit.cc
>> Compiling  src/L1Trigger/L1TMuonBarrel/src/L1MuBMDataBuffer.cc


@iarspider iarspider marked this pull request as draft April 7, 2024 15:44
@iarspider
Copy link
Contributor Author

@cms-sw/analysis-l2 @cms-sw/dqm-l2 @cms-sw/l1-l2 @cms-sw/simulation-l2 @cms-sw/upgrade-l2 could you please review and sign? Thanks!

@aloeliger
Copy link
Contributor

+l1

  • technical PR

@mandrenguyen
Copy link
Contributor

+1

@srimanob
Copy link
Contributor

+Upgrade

@civanch
Copy link
Contributor

civanch commented Apr 10, 2024

+1

@tvami
Copy link
Contributor

tvami commented Apr 10, 2024

+1

@iarspider
Copy link
Contributor Author

@cms-sw/dqm-l2 gentle ping

@tjavaid
Copy link

tjavaid commented Apr 17, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

Failures are unrelated to this PR

@rappoccio
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 03a39ed into cms-sw:master Apr 18, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment