Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the #include files for ROCm v6.x #44777

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Apr 18, 2024

PR description:

ROCm 6.0 moved rocm_version.h to rocm-core/rocm_version.h.

PR validation:

The modified code builds with cms-sw/cmsdist#9143 .

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

No backport is foreseen.

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 18, 2024

please test with cms-sw/cmsdist#9143

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 18, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44777/40010

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard for master.

It involves the following packages:

  • HeterogeneousCore/ROCmServices (heterogeneous)

@fwyzard, @makortel can you please review it and eventually sign? Thanks.
@missirol, @rovere, @makortel this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bd2967/38940/summary.html
COMMIT: b41c9e7
CMSSW: CMSSW_14_1_X_2024-04-18-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44777/38940/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bd2967/38940/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bd2967/38940/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS

Comparison Summary

Summary:

@smuzaffar
Copy link
Contributor

ignore tests-rejected with ib-failure

@cmsbuild
Copy link
Contributor

REMINDER @antoniovilela, @sextonkennedy, @rappoccio: This PR was tested with cms-sw/cmsdist#9143, please check if they should be merged together

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 19, 2024

+heterogeneous

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cmsdist#9143

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 22, 2024

@cms-sw/orp-l2 could you merge this and cms-sw/cmsdist#9143 for the next IB ?

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d9da9e0 into cms-sw:master Apr 22, 2024
10 of 11 checks passed
@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 22, 2024

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants