miscellaneous improvements to LSNumberFilter

[mmusich]

PR description:

Quick followup on top of #44783.
Some miscellaneous improvements to the LSNumberFilter (mainly adding a fillDescriptions method and use it for configuring the Tk Al PCL modules).

PR validation:

PR was validated by testing the MilleStep for one nominal run (Run 379530) and the Lumiscan run (Run 379524), using the following command:

cmsDriver.py milleStep \
	     -s ALCA:PromptCalibProdSiPixelAli \
	     --conditions 140X_dataRun3_Express_v2 \
	     --scenario pp \
	     --data \
	     --era Run3 \
	     --datatier ALCARECO \
	     --eventcontent ALCARECO \
	     --processName=ReAlCa \
	     -n 100 \
	     --dasquery='file dataset=/StreamExpress/Run2024C-TkAlMinBias-Express-v1/ALCARECO run=379530'

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but will be backported together with #44783 to CMSSW_14_0_X.

[cmsbuild]

cms-bot internal usage

[mmusich]

test parameters:

• workflows = 1001.0, 1001.2, 1001.3, 1001.4, 1002.3

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44810/40060

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Alignment/CommonAlignmentProducer/python/ALCARECOPromptCalibProdSiPixelAli0T_cff.py modified in PR(s): [Dummy] Try creating big-enough cache to cause splitting #44368
  • File Alignment/CommonAlignmentProducer/python/ALCARECOPromptCalibProdSiPixelAliHGDiMuon_cff.py modified in PR(s): [Dummy] Try creating big-enough cache to cause splitting #44368
  • File Alignment/CommonAlignmentProducer/python/ALCARECOPromptCalibProdSiPixelAliHG_cff.py modified in PR(s): [Dummy] Try creating big-enough cache to cause splitting #44368
  • File Alignment/CommonAlignmentProducer/python/ALCARECOPromptCalibProdSiPixelAli_cff.py modified in PR(s): [Dummy] Try creating big-enough cache to cause splitting #44368
  • File Alignment/CommonAlignmentProducer/python/LSNumberFilter_cfi.py modified in PR(s): [Dummy] Try creating big-enough cache to cause splitting #44368
  • File Alignment/CommonAlignmentProducer/python/customizeLSNumberFilterForRelVals.py modified in PR(s): [Dummy] Try creating big-enough cache to cause splitting #44368

[cmsbuild]

A new Pull Request was created by @mmusich for master.

It involves the following packages:

• Alignment/CommonAlignmentProducer (alca)

@cmsbuild, @perrotta, @consuegs, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@pakhotin, @rsreds, @mmusich, @yuanchao, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[cmsbuild]

-1

Failed Tests: Build ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f2e41e/39026/summary.html
COMMIT: 1830e6e
CMSSW: CMSSW_14_1_X_2024-04-22-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44810/39026/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @jonamotta Calo Layer-2 EG/TAU conditions for 2024 #44681
• @bsunanda Phase2-sim156 Update the scripts to enable run on new scenarios of Phase2 geometry #44662
• @phnattla HLT Menu check for the PCL Tracker Alignment #44783
• @NJManganelli Phase 2 GTT Add Extended Jets to buffers for GlobalTrigger #44696
• @fwyzard Revert "CalorimeterDefinitions: don't return -1 as uint32_t" #44788
• @fwyzard Skip invalid HCAL PF rechits in PFRecHitTopologyESProducer #44790
• @mmusich add a unit test for convertToRaw #44771
• @fwyzard Update the #include files for ROCm v6.x #44777
• @SohamBhattacharya [Phase-2] [14_1_X] Configuration for Phase-2 HLT path validation #44776

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f2e41e/39026/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f2e41e/39026/git-merge-result

Build

I found compilation error when building:

>> Leaving Package HeterogeneousCore/ROCmServices
>> Package HeterogeneousCore/ROCmServices built
Entering library rule at src/HeterogeneousCore/ROCmServices/plugins
>> Compiling edm plugin src/HeterogeneousCore/ROCmServices/plugins/ROCmMonitoringService.cc
>> Compiling edm plugin src/HeterogeneousCore/ROCmServices/plugins/ROCmService.cc
src/HeterogeneousCore/ROCmServices/plugins/ROCmService.cc:9:10: fatal error: rocm-core/rocm_version.h: No such file or directory
    9 | #include 
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
gmake: *** [tmp/el8_amd64_gcc12/src/HeterogeneousCore/ROCmServices/plugins/HeterogeneousCoreROCmServicesPlugins/ROCmService.cc.o] Error 1
>> Building edm plugin tmp/el8_amd64_gcc12/src/HeterogeneousCore/ROCmServices/plugins/HeterogeneousCoreROCmServicesPlugins/libHeterogeneousCoreROCmServicesPlugins.so


Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

>> Entering Package L1Trigger/DemonstratorTools
>> Entering Package L1Trigger/L1TCalorimeter
>> Entering Package RecoParticleFlow/PFRecHitProducer
>> Entering Package Validation/Geometry
>> Compile sequence completed for CMSSW CMSSW_14_1_X_2024-04-22-1100
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1
+ eval scram build outputlog '&&' '(python3' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cms-bot/buildLogAnalyzer.py --logDir /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_X_2024-04-22-1100/tmp/el8_amd64_gcc12/cache/log/src '||' 'true)'
++ scram build outputlog
>> Entering Package Alignment/CommonAlignmentProducer
Entering library rule at src/Alignment/CommonAlignmentProducer/plugins
>> Compiling edm plugin src/Alignment/CommonAlignmentProducer/plugins/FakeAlignmentProducer.cc


[mmusich]

@cmsbuild, please test

• let's see if with the new IB works fine.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f2e41e/39038/summary.html
COMMIT: 1830e6e
CMSSW: CMSSW_14_1_X_2024-04-23-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44810/39038/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
25088.203 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• You potentially added 19 lines to the logs
• Reco comparison results: 44 differences found in the comparisons
• DQMHistoTests: Total files compared: 52
• DQMHistoTests: Total histograms compared: 3349844
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3349821
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 51 files compared)
• Checked 223 log files, 169 edm output root files, 52 DQM output files
• TriggerResults: no differences found

[perrotta]

+alca

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1