Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Phase-2] [14_1_X] Configuration for Phase-2 HLT path validation #44776

Merged

Conversation

SohamBhattacharya
Copy link
Contributor

@SohamBhattacharya SohamBhattacharya commented Apr 18, 2024

This PR adds the configuration for Phase-2 HLT path validation (see issue #44761).
Tested locally that it produces an output file with path efficiencies.

No changes are expected from this PR.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 18, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44776/40008

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @SohamBhattacharya for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @mmusich, @cmsbuild can you please review it and eventually sign? Thanks.
@missirol, @rovere, @Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Apr 18, 2024

please test

  • albeit there is nothing to test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8cbec4/38943/summary.html
COMMIT: 696ac12
CMSSW: CMSSW_14_1_X_2024-04-18-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44776/38943/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@swagata87
Copy link
Contributor

Does the pt range for egamma ends at 150 GeV in this validation? For following HLT paths, we need to extend that..

     "HLT_Photon108EB_TightID_TightIso_L1Seeded",
     "HLT_Photon108EB_TightID_TightIso_Unseeded",
     "HLT_Photon187_L1Seeded",
     "HLT_Photon187_Unseeded"

If you use a Z'->EE sample (few TeV Z' mass), then its very convenient to get egamma objects of all pT range up to TeV scale (due to the off-shell component we also get the low/medium pT egamma)

@SohamBhattacharya
Copy link
Contributor Author

SohamBhattacharya commented Apr 19, 2024

Thanks for the tip on these paths.
Indeed, the configuration will need modification. This PR is just to get the paths into configuration first. We'll have to get the histogram binnings checked by the pogs.
This tool is quite flexible, for example, it can have path specific bins too.
I can add a few more high pt bins for now.

@mmusich
Copy link
Contributor

mmusich commented Apr 22, 2024

+hlt

  • adds a standalone utility for the phase-2 HLT path validation
  • @SohamBhattacharya to make this more useful I guess this should be interlaced with the regular release validation configurations. Is there any plans about that?

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@SohamBhattacharya
Copy link
Contributor Author

+hlt

* adds a standalone utility for the phase-2 HLT path validation

* @SohamBhattacharya to make this more useful I guess this should be interlaced with the regular release validation configurations. Is there any plans about that?

@mmusich yes, that is indeed the plan. I'll move this conversation on how to proceed with that, to #44761.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44776/40033

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

Pull request #44776 was updated. @Martin-Grunewald, @mmusich, @cmsbuild can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Apr 22, 2024

@SohamBhattacharya please clarify if more updates to this branch are foreseen

@SohamBhattacharya
Copy link
Contributor Author

@SohamBhattacharya please clarify if more updates to this branch are foreseen

No, that's all for this PR.

@mmusich
Copy link
Contributor

mmusich commented Apr 22, 2024

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8cbec4/38990/summary.html
COMMIT: 590182e
CMSSW: CMSSW_14_1_X_2024-04-22-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44776/38990/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 44 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3319852
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3319826
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@rappoccio
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants