BrokenLineFit and RiemannFit: mask asserts behind DEBUG flags

[mmusich]

PR description:

Fixes #44786.
As described in the issue this will avoid triggering assertion failures on GPU when running the example in #44786 (comment), this - incidentally - is also the status quo on CUDA, see #44786 (comment).
Implements masking assertions behind compilation flag BROKENLINE_DEBUG as per #44786 (comment).

PR validation:

#!/bin/bash -ex

# CMSSW_14_0_5_patch2

hltGetConfiguration run:379617 \
  --globaltag 140X_dataRun3_HLT_v3 \
  --data \
  --no-prescale \
  --no-output \
  --max-events -1 \
  --input /store/group/tsg/FOG/debug/240417_run379617/run379617_ls0329_index000242_fu-c2b02-12-01_pid3327112.root  > hlt.py
  
cmsRun hlt.py &> hlt.log

runs fine in this branch.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, might want to backport to CMSSW_14_0_X for the next online data-taking release.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44801/40042

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoTracker/PixelSeeding/plugins/alpaka/BrokenLineFit.dev.cc modified in PR(s): Alpaka vs CUDA DQM compare modules for pixel tracks objects #43964

[cmsbuild]

A new Pull Request was created by @mmusich for master.

It involves the following packages:

• RecoTracker/PixelSeeding (reconstruction)

@cmsbuild, @mandrenguyen, @jfernan2 can you please review it and eventually sign? Thanks.
@mtosi, @mmusich, @missirol, @GiacomoSguazzoni, @VourMa, @rovere, @felicepantaleo, @VinInn, @gpetruc, @JanFSchulte, @dgulhan this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[fwyzard]

@mmusich , there is an identical check also in RecoTracker/PixelSeeding/plugins/alpaka/RiemannFit.dev.cc.
Could you update that in the same way ?

[mmusich]

Could you update that in the same way ?

thanks for the suggestions. All implemented now.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44801/40056

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoTracker/PixelSeeding/plugins/alpaka/BrokenLineFit.dev.cc modified in PR(s): Alpaka vs CUDA DQM compare modules for pixel tracks objects #43964
  • File RecoTracker/PixelSeeding/plugins/alpaka/RiemannFit.dev.cc modified in PR(s): Alpaka vs CUDA DQM compare modules for pixel tracks objects #43964

[cmsbuild]

Pull request #44801 was updated. @mandrenguyen, @cmsbuild, @jfernan2 can you please check and sign again.

[mmusich]

test parameters:

• enable = gpu
• workflows = 12434.402,12434.403,12434.404
• workflows_gpu = 12434.402,12434.403,12434.404
• workflow_opts = -w upgrade
• workflow_opts_gpu = -w upgrade

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-939360/39018/summary.html
COMMIT: 3c36fcd
CMSSW: CMSSW_14_1_X_2024-04-22-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44801/39018/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 15 lines from the logs
• Reco comparison results: 39 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3351925
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3351898
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 213 log files, 177 edm output root files, 50 DQM output files
• TriggerResults: no differences found

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 20 differences found in the comparisons
• DQMHistoTests: Total files compared: 5
• DQMHistoTests: Total histograms compared: 71813
• DQMHistoTests: Total failures: 926
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 70887
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 4 files compared)
• Checked 19 log files, 22 edm output root files, 5 DQM output files
• TriggerResults: no differences found

[mmusich]

urgent

[antoniovilela]

I have the impression this -as is - will be rejected, but opening just in case we need it later.

Why?

[mmusich]

Why?

the discussion at #44786 was not yet fully converged. Removed.

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1