[14.0.X] BrokenLineFit and RiemannFit: mask asserts behind DEBUG flags

[mmusich]

backport of #44801

PR description:

Fixes #44786.
As described in the issue this will avoid triggering assertion failures on GPU when running the example in #44786 (comment), this - incidentally - is also the status quo on CUDA, see #44786 (comment).
Implements masking assertions behind compilation flag BROKENLINE_DEBUG as per #44786 (comment).

PR validation:

#!/bin/bash -ex

# CMSSW_14_0_5_patch2

hltGetConfiguration run:379617 \
  --globaltag 140X_dataRun3_HLT_v3 \
  --data \
  --no-prescale \
  --no-output \
  --max-events -1 \
  --input /store/group/tsg/FOG/debug/240417_run379617/run379617_ls0329_index000242_fu-c2b02-12-01_pid3327112.root  > hlt.py
  
cmsRun hlt.py &> hlt.log

runs fine in this branch.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

verbatim backport of #44801 to 14.0.X for HLT online data-taking purposes.

[cmsbuild]

A new Pull Request was created by @mmusich for CMSSW_14_0_X.

It involves the following packages:

• RecoTracker/PixelSeeding (reconstruction)

@jfernan2, @cmsbuild, @mandrenguyen can you please review it and eventually sign? Thanks.
@felicepantaleo, @gpetruc, @JanFSchulte, @missirol, @dgulhan, @mmusich, @mtosi, @GiacomoSguazzoni, @rovere, @VourMa, @VinInn this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

• Backported from BrokenLineFit and RiemannFit: mask asserts behind DEBUG flags #44801

[cmsbuild]

cms-bot internal usage

[mmusich]

test parameters:

• enable = gpu
• workflows = 12434.402,12434.403,12434.404
• workflows_gpu = 12434.402,12434.403,12434.404
• workflow_opts = -w upgrade
• workflow_opts_gpu = -w upgrade

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e73b79/39019/summary.html
COMMIT: 1f47513
CMSSW: CMSSW_14_0_X_2024-04-22-2300/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44808/39019/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 83 lines to the logs
• Reco comparison results: 60 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3351161
• DQMHistoTests: Total failures: 1363
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3349778
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 213 log files, 177 edm output root files, 50 DQM output files
• TriggerResults: no differences found

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 46 differences found in the comparisons
• DQMHistoTests: Total files compared: 5
• DQMHistoTests: Total histograms compared: 71813
• DQMHistoTests: Total failures: 1643
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 70170
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 4 files compared)
• Checked 19 log files, 22 edm output root files, 5 DQM output files
• TriggerResults: no differences found

[mmusich]

urgent

• for the next HLT online release

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1