skip bad channels in PFRecHitProducerKernelConstruct<T>::applyCuts

[mmusich]

PR description:

This PR is a simple fix for #45595 and implements the suggestion at #45595 (comment)
Skips bad channels in PFRecHitProducerKernelConstruct<T>::applyCuts

• as implemented in HcalRecHitSoAToLegacy
• also check denseId validity before retrieving the corresponding PF threshold

PR validation:

Run successfully the reproducer script at #45595 (comment).

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, we might backported it if accepted. In that case we'll need an urgent patch on to of CMSSW_14_0_13

[cmsbuild]

cms-bot internal usage

[mmusich]

assign heterogeneous

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45604/41096

[cmsbuild]

New categories assigned: heterogeneous

@fwyzard,@makortel you have been requested to review this Pull request/Issue and eventually sign? Thanks

[cmsbuild]

A new Pull Request was created by @mmusich for master.

It involves the following packages:

• RecoParticleFlow/PFRecHitProducer (reconstruction)

@cmsbuild, @fwyzard, @jfernan2, @makortel, @mandrenguyen can you please review it and eventually sign? Thanks.
@hatakeyamak, @lgray, @missirol, @mmarionncern, @seemasharmafnal this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

enable gpu

[mmusich]

test parameters:

• workflow_opts_gpu= -w upgrade
• workflows_gpu=12434.422, 12434.423,12434.424,12434.492

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f45c0b/40704/summary.html
COMMIT: 2155a8b
CMSSW: CMSSW_14_1_X_2024-07-30-2300/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45604/40704/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 9 lines to the logs
• Reco comparison results: 87 differences found in the comparisons
• DQMHistoTests: Total files compared: 45
• DQMHistoTests: Total histograms compared: 3423961
• DQMHistoTests: Total failures: 2464
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3421477
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
• Checked 196 log files, 165 edm output root files, 45 DQM output files
• TriggerResults: no differences found

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 1012 differences found in the comparisons
• DQMHistoTests: Total files compared: 7
• DQMHistoTests: Total histograms compared: 156599
• DQMHistoTests: Total failures: 71
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 156528
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
• Checked 27 log files, 35 edm output root files, 7 DQM output files
• TriggerResults: no differences found

[fwyzard]

+heterogeneous

[mandrenguyen]

type bug-fix

[mandrenguyen]

+1
Backport expected

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

[mmusich]

type pf