-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0.X] skip bad channels in PFRecHitProducerKernelConstruct<T>::applyCuts
#45611
[14.0.X] skip bad channels in PFRecHitProducerKernelConstruct<T>::applyCuts
#45611
Conversation
- as implemented in HcalRecHitSoAToLegacy - also check denseId validity before retrieving PF threshold
type pf |
A new Pull Request was created by @mmusich for CMSSW_14_0_X. It involves the following packages:
@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
cms-bot internal usage |
urgent |
type bug-fix |
please test |
+1 Size: This PR adds an extra 16KB to repository Comparison SummarySummary:
|
+reconstruction |
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
backport of #45604
PR description:
This PR is a simple fix for #45595 and implements the suggestion at #45595 (comment)
Skips bad channels in
PFRecHitProducerKernelConstruct<T>::applyCuts
HcalRecHitSoAToLegacy
denseId
validity before retrieving the corresponding PF thresholdPR validation:
Run successfully the reproducer script at #45595 (comment).
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Verbatim backport of #45604 to the 2024 data-taking release cycle